From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbbIYGoK (ORCPT ); Fri, 25 Sep 2015 02:44:10 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:25640 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754958AbbIYGoH (ORCPT ); Fri, 25 Sep 2015 02:44:07 -0400 X-AuditID: cbfec7f5-f794b6d000001495-f2-5604ed347773 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Tejun Heo , linux-ide@vger.kernel.org Subject: [PATCH v2 03/19] libata: samsung_cf: fix handling platform_get_irq result Date: Fri, 25 Sep 2015 08:43:31 +0200 Message-id: <1443163411-25668-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <20150924145317.GA25415@mtj.duckdns.org> References: <20150924145317.GA25415@mtj.duckdns.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjluLIzCtJLcpLzFFi42I5/e/4ZV2TtyxhBs+uG1jcWneO1WLjjPWs Fsd2PGKyuLxrDpvF2iN32S1+LT/K6MDmsWlVJ5tH35ZVjB6fN8kFMEdx2aSk5mSWpRbp2yVw ZUzauYSlYCdbxdV3y9kaGDezdjFyckgImEjs+PKGEcIWk7hwbz1bFyMXh5DAUkaJqyu3sEI4 TUwS0/9sYQOpYhPQlPi7+SaYLSKgILG59xlYEbPAMUaJeb+egCWEBUIkzm1oBrNZBFQlZhyb yQRi8wo4S5yY85INYp2cxMljk8HO4BQwlbj3pYsZxBYCOunHhyksExh5FzAyrGIUTS1NLihO Ss810itOzC0uzUvXS87P3cQICZ2vOxiXHrM6xCjAwajEw6vQyhImxJpYVlyZe4hRgoNZSYRX az9QiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/MXe9DhATSE0tSs1NTC1KLYLJMHJxSDYxai/Zm mMt5NV6X7RA9vm3fksA/83MvNvHH37RPiA1sXbd+96+PLx4Im0u82Oj2gZv9JLvyRCHveQ+d ykyW2nceeP1y5/7UmceD9t+2VMlxNtjyaqLAxOkdPmcu/Xylu0EiQ/RVrn3UwlM7Hx31f9Qx K+//ht4rK3Nn2L41nfZz8vevBW+XCq1KVmIpzkg01GIuKk4EAFrYyNgZAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- v2: changed type of irq field --- drivers/ata/pata_samsung_cf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c index cbb5a47..f6facd6 100644 --- a/drivers/ata/pata_samsung_cf.c +++ b/drivers/ata/pata_samsung_cf.c @@ -70,7 +70,7 @@ struct s3c_ide_info { struct clk *clk; void __iomem *ide_addr; void __iomem *sfr_addr; - unsigned int irq; + int irq; enum s3c_cpu_type cpu_type; unsigned int fifo_status_reg; }; -- 1.9.1