From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755362AbbIYGqT (ORCPT ); Fri, 25 Sep 2015 02:46:19 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:10261 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754145AbbIYGqQ (ORCPT ); Fri, 25 Sep 2015 02:46:16 -0400 X-AuditID: cbfec7f5-f794b6d000001495-64-5604edb56f11 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned Date: Fri, 25 Sep 2015 08:45:43 +0200 Message-id: <1443163543-25733-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <560446A2.2020907@iogearbox.net> References: <560446A2.2020907@iogearbox.net> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmluLIzCtJLcpLzFFi42I5/e/4Zd2tb1nCDLp/KFvcWneO1WLjjPWs FnPOt7BYXN41h81i7ZG77BbHFog5sHlsWXmTyaNvyypGj8+b5AKYo7hsUlJzMstSi/TtErgy rnUfZilYw17xd+J29gbGLrYuRk4OCQETiSkTN7JD2GISF+6tB4pzcQgJLGWUuL/gFzOE08Qk cXDJVLAqNgFNib+bb4J1iwgoSGzufcYKYjMLXGSUmLZfGcQWFoiSuLHrBFg9i4CqxIa+3Yxd jBwcvALOEnPW8EAsk5M4eWwyWCungK5E45XXjCC2kICOxONz09gmMPIuYGRYxSiaWppcUJyU nmukV5yYW1yal66XnJ+7iRESNF93MC49ZnWIUYCDUYmHV6GVJUyINbGsuDL3EKMEB7OSCK/W fqAQb0piZVVqUX58UWlOavEhRmkOFiVx3pm73ocICaQnlqRmp6YWpBbBZJk4OKUaGKPe/L1T POlF/5UzT1YY8t16L27w0kk3ZPNqyztbf/w8FNX/U3dT+R3zU9GvJs7ZZlfFKdRksv65oQ2r Q0Xb/dXc97cu2um2dP0+p67dngk35J7qR22rXCnAe/jftdgrh5g/3c0w672mVR9ftS7r4yTe gLenbC96xp/d5rvevvrGp6dnjdm+i9kqsRRnJBpqMRcVJwIAYOlOfhYCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function returns always non-negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- v2: fixed indentation --- tools/net/bpf_jit_disasm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/net/bpf_jit_disasm.c b/tools/net/bpf_jit_disasm.c index 2cd3d4c..5b32413 100644 --- a/tools/net/bpf_jit_disasm.c +++ b/tools/net/bpf_jit_disasm.c @@ -156,8 +156,8 @@ static void put_log_buff(char *buff) free(buff); } -static int get_last_jit_image(char *haystack, size_t hlen, - uint8_t *image, size_t ilen) +static unsigned int get_last_jit_image(char *haystack, size_t hlen, + uint8_t *image, size_t ilen) { char *ptr, *pptr, *tmp; off_t off = 0; -- 1.9.1