From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755629AbbIYIaS (ORCPT ); Fri, 25 Sep 2015 04:30:18 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48928 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755216AbbIYIaN (ORCPT ); Fri, 25 Sep 2015 04:30:13 -0400 Message-ID: <1443169791.4397.38.camel@pengutronix.de> Subject: Re: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin From: Philipp Zabel To: Russell King - ARM Linux , Thierry Reding Cc: Douglas Anderson , airlied@linux.ie, fabio.estevam@freescale.com, ykk@rock-chips.com, andy.yan@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Date: Fri, 25 Sep 2015 10:29:51 +0200 In-Reply-To: <20150921141541.GO21084@n2100.arm.linux.org.uk> References: <1442436098-26608-1-git-send-email-dianders@chromium.org> <20150921095104.GB20992@ulmo.nvidia.com> <20150921141541.GO21084@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 21.09.2015, 15:15 +0100 schrieb Russell King - ARM Linux: > On Mon, Sep 21, 2015 at 11:51:06AM +0200, Thierry Reding wrote: > > On Wed, Sep 16, 2015 at 01:41:38PM -0700, Douglas Anderson wrote: > > > There's a member in 'struct dw_hdmi' called cable_plugin. It's never > > > set to anything anywhere so thus is always false. There's a bit of code > > > checking it, but since it's always false this must be dead code. > > > Eliminate it. > > > > > > Note: if someone wants to figure out the intention of the original code > > > and implement whatever feature / fix was needed then we can drop this > > > patch. The 'cable_plugin' member has been unused since the code was > > > first added in (9aaf880 imx-drm: Add mx6 hdmi transmitter support). > > > > > > Signed-off-by: Douglas Anderson > > > --- > > > drivers/gpu/drm/bridge/dw_hdmi.c | 9 --------- > > > 1 file changed, 9 deletions(-) > > > > Except for the CHROMIUM: prefix this looks good to me: > > > > Reviewed-by: Thierry Reding This seems to be similar to Sascha's "drm: bridge/dw_hdmi: remove unused code" patch, except that the hdmi_disable_overflow_interrupts function could be removed too. > > Russell, do you have patches to this driver queued for v4.4 and plan to > > pick this up into your tree or should I take it? > > My current patch stack for imx-drm related stuff looks like this at > present: > > drm: bridge/dw_hdmi: place PHY into low power mode when disabled > drm: bridge/dw_hdmi: start of support for pixel doubled modes > drm: bridge/dw_hdmi: remove CEC engine register definitions > drm: bridge/dw_hdmi-cec: add Designware HDMI CEC driver > cec: add HDMI CEC input driver > cec: add HDMI CEC core driver > drm: bridge/dw_hdmi: replace CTS calculation for the ACR > drm: bridge/dw_hdmi: remove ratio support from ACR code > drm: bridge/dw_hdmi: adjust pixel clock values in N calculation > drm: bridge/dw_hdmi: avoid being recursive in N calculation > drm: bridge/dw_hdmi-ahb-audio: allow larger buffer sizes > drm: bridge/dw_hdmi-ahb-audio: basic support for multi-channel PCM audio > drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver > drm: bridge/dw_hdmi-ahb-audio: add audio driver > drm: bridge/dw_hdmi: improve HDMI enable/disable handling > drm: bridge/dw_hdmi: add connector mode forcing > drm: bridge/dw_hdmi: add support for interlaced video modes > gpu: imx: fix support for interlaced modes > gpu: imx: simplify sync polarity setting > > I haven't yet decided what, if anything, from that stack I'm going to > try to get into the next merge window. Given the lack of interest last > time I posted these patches, I'm loosing interest myself in trying to > get them merged, especially ones which are getting on for being 2 years > old. I'm still very interested to see at least the "gpu: imx: fix support for interlaced modes" and "gpu: imx: simplify sync polarity setting" merged. May I take them into the imx-drm tree separately? Or, if I can influence your decision in this matter, I'd prefer if you could once more resend last month's series with Thierry in Cc:, and he'd either queue them with my Ack for the imx-drm patches or give his Ack for you or me to queue them. regards Philipp