mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] drm/imx: Build monolithic driver
Date: Fri, 25 Sep 2015 15:09:18 +0200	[thread overview]
Message-ID: <1443186558.4397.72.camel@pengutronix.de> (raw)
In-Reply-To: <20150925121735.GA30567@ulmo>

Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding:
> I think you gain much less by splitting up than you realize. Compare
> this from before the series:
> 
> 	$ du -ch drivers/gpu/drm/imx/*.ko
> 	8.0K    drivers/gpu/drm/imx/dw_hdmi-imx.ko

Oh right, I didn't realize that this is just the shim. The bulk of the
HDMI driver is in bridge/dw_hdmi.ko.

> 	16K     drivers/gpu/drm/imx/imxdrm.ko
> 	16K     drivers/gpu/drm/imx/imx-ipuv3-crtc.ko
> 	12K     drivers/gpu/drm/imx/imx-ldb.ko
> 	12K     drivers/gpu/drm/imx/imx-tve.ko
> 	8.0K    drivers/gpu/drm/imx/parallel-display.ko
> 	72K     total
[...]
> with this after the series:
> 
> 	$ du -ch drivers/gpu/drm/imx/*.ko
> 	44K     drivers/gpu/drm/imx/imx-drm.ko
> 	44K     total
[...]
> There are other things to consider as well, such as the additional
> memory overhead caused by merely having multiple modules, or all of the
> exported functions that unnecessarily clutter up the symbol table, and
> which end up slowing down every symbol lookup.

Thanks, can't argue with those numbers.
I'll queue patches 3 and 4 for imx-drm.

regards
Philipp


  reply	other threads:[~2015-09-25 13:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 17:02 [PATCH 1/6] driver-core: platform: Provide helpers for multi-driver modules Thierry Reding
2015-09-24 17:02 ` [PATCH 2/6] drm/tegra: Use new multi-driver module helpers Thierry Reding
2015-09-24 17:02 ` [PATCH 3/6] drm/imx: Build monolithic driver Thierry Reding
2015-09-25  7:16   ` Philipp Zabel
2015-09-25 12:17     ` Thierry Reding
2015-09-25 13:09       ` Philipp Zabel [this message]
2015-09-25 13:13         ` Philipp Zabel
2015-09-25 14:21           ` Thierry Reding
2015-09-24 17:02 ` [PATCH 4/6] drm/imx: Do not export symbols Thierry Reding
2015-09-24 17:02 ` [PATCH 5/6] drm/sti: Build monolithic driver Thierry Reding
2015-10-05  8:22   ` Vincent ABRIOU
2015-09-24 17:02 ` [PATCH 6/6] drm/sti: Do not export symbols Thierry Reding
2015-10-05  8:22   ` Vincent ABRIOU
2015-09-25 10:27 ` [PATCH 1/6] driver-core: platform: Provide helpers for multi-driver modules Jani Nikula
2015-09-25 15:15   ` Thierry Reding
2015-09-28  6:37     ` Jani Nikula
2015-09-25 14:29 ` Thierry Reding
2015-09-26  0:55   ` Greg Kroah-Hartman
2015-09-25 15:23 ` Thierry Reding
2015-09-25 15:29 ` [PATCH v2] " Thierry Reding
2015-09-28  6:46   ` Andy Shevchenko
2015-09-28  9:05 ` [PATCH 1/6] " Daniel Vetter
2015-09-28 19:19   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443186558.4397.72.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome