From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756279AbbIYNN5 (ORCPT ); Fri, 25 Sep 2015 09:13:57 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54474 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756114AbbIYNN4 (ORCPT ); Fri, 25 Sep 2015 09:13:56 -0400 Message-ID: <1443186834.4397.76.camel@pengutronix.de> Subject: Re: [PATCH 3/6] drm/imx: Build monolithic driver From: Philipp Zabel To: Thierry Reding Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 25 Sep 2015 15:13:54 +0200 In-Reply-To: <1443186558.4397.72.camel@pengutronix.de> References: <1443114161-7965-1-git-send-email-thierry.reding@gmail.com> <1443114161-7965-3-git-send-email-thierry.reding@gmail.com> <1443165366.4397.4.camel@pengutronix.de> <20150925121735.GA30567@ulmo> <1443186558.4397.72.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 25.09.2015, 15:09 +0200 schrieb Philipp Zabel: > Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding: > > I think you gain much less by splitting up than you realize. Compare > > this from before the series: > > > > $ du -ch drivers/gpu/drm/imx/*.ko > > 8.0K drivers/gpu/drm/imx/dw_hdmi-imx.ko > > Oh right, I didn't realize that this is just the shim. The bulk of the > HDMI driver is in bridge/dw_hdmi.ko. > > > 16K drivers/gpu/drm/imx/imxdrm.ko > > 16K drivers/gpu/drm/imx/imx-ipuv3-crtc.ko > > 12K drivers/gpu/drm/imx/imx-ldb.ko > > 12K drivers/gpu/drm/imx/imx-tve.ko > > 8.0K drivers/gpu/drm/imx/parallel-display.ko > > 72K total > [...] > > with this after the series: > > > > $ du -ch drivers/gpu/drm/imx/*.ko > > 44K drivers/gpu/drm/imx/imx-drm.ko > > 44K total > [...] > > There are other things to consider as well, such as the additional > > memory overhead caused by merely having multiple modules, or all of the > > exported functions that unnecessarily clutter up the symbol table, and > > which end up slowing down every symbol lookup. > > Thanks, can't argue with those numbers. > I'll queue patches 3 and 4 for imx-drm. Wait, I won't because they depend on the helper function in patch 1. Acked-by: Philipp Zabel then. Can I get a stable tag so I can solve potential merge conflicts in imx-drm-core.c? regards Philipp