From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756574AbbIYOGJ (ORCPT ); Fri, 25 Sep 2015 10:06:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:36671 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756355AbbIYOGH (ORCPT ); Fri, 25 Sep 2015 10:06:07 -0400 Subject: Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c From: Jean Delvare To: Matt Fleming Cc: Jim Davis , Stephen Rothwell , linux-next , linux-kernel , wsa@the-dreams.de, linux-i2c@vger.kernel.org, Matt Fleming , Guenter Roeck In-Reply-To: <20150925133757.GA2857@codeblueprint.co.uk> References: <20150925093610.64ed7f59@endymion.delvare> <20150925133757.GA2857@codeblueprint.co.uk> Content-Type: text/plain; charset="UTF-8" Organization: Suse Linux Date: Fri, 25 Sep 2015 16:06:04 +0200 Message-ID: <1443189964.4919.5.camel@chaos.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Friday 25 September 2015 à 14:37 +0100, Matt Fleming a écrit : > On Fri, 25 Sep, at 09:36:10AM, Jean Delvare wrote: > > On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote: > > > Building with the attached random configuration file, > > > > > > drivers/built-in.o: In function `dmi_check_onboard_devices': > > > i2c-i801.c:(.text+0x126b36): undefined reference to `i2c_new_device' > > > drivers/built-in.o: In function `i801_remove': > > > i2c-i801.c:(.text+0x126b86): undefined reference to `i2c_del_adapter' > > > drivers/built-in.o: In function `i801_probe': > > > i2c-i801.c:(.text+0x127d08): undefined reference to `i2c_add_adapter' > > > i2c-i801.c:(.text+0x127d6e): undefined reference to `i2c_new_device' > > > > Sorry for the late reply. The error is caused by the following > > combination of options: > > > > CONFIG_I2C=m > > CONFIG_I2C_I801=y > > > > I can reproduce it even with mainline now. This is caused by > > CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting > > its dependencies (CONFIG_I2C.) > > > > Thanks for reporting, I'll post a fix shortly. > > Sorry that you got caught up in this build error Jean. No big deal :) > Guenter (Cc'd) posted a fix here, > > https://lkml.kernel.org/r/1441978088-27288-1-git-send-email-linux@roeck-us.net Actually I prefer Guenter's approach. I am never comfortable with drivers selecting subsystems. So you can add: Acked-by: Jean Delvare to Guenter's patch and drop mine. Thanks, -- Jean Delvare SUSE L3 Support