From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] selinux: use kmemdup in security_sid_to_context_core()
Date: Sat, 26 Sep 2015 00:34:17 +0200 [thread overview]
Message-ID: <1443220459-11042-4-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <1443220459-11042-1-git-send-email-linux@rasmusvillemoes.dk>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
security/selinux/ss/services.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index c550df0e0ff1..994c824a34c6 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -1259,12 +1259,12 @@ static int security_sid_to_context_core(u32 sid, char **scontext,
*scontext_len = strlen(initial_sid_to_string[sid]) + 1;
if (!scontext)
goto out;
- scontextp = kmalloc(*scontext_len, GFP_ATOMIC);
+ scontextp = kmemdup(initial_sid_to_string[sid],
+ *scontext_len, GFP_ATOMIC);
if (!scontextp) {
rc = -ENOMEM;
goto out;
}
- strcpy(scontextp, initial_sid_to_string[sid]);
*scontext = scontextp;
goto out;
}
--
2.1.3
next prev parent reply other threads:[~2015-09-25 22:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 22:34 [PATCH 0/5] selinux: minor cleanup suggestions Rasmus Villemoes
2015-09-25 22:34 ` [PATCH 1/5] selinux: introduce security_context_str_to_sid Rasmus Villemoes
2015-09-29 18:02 ` Stephen Smalley
2015-09-30 16:28 ` Paul Moore
2015-09-25 22:34 ` [PATCH 2/5] selinux: remove pointless cast in selinux_inode_setsecurity() Rasmus Villemoes
2015-09-29 18:08 ` Stephen Smalley
2015-09-30 16:31 ` Paul Moore
2015-09-25 22:34 ` Rasmus Villemoes [this message]
2015-09-29 18:11 ` [PATCH 3/5] selinux: use kmemdup in security_sid_to_context_core() Stephen Smalley
2015-09-30 16:37 ` Paul Moore
2015-09-25 22:34 ` [PATCH 4/5] selinux: use kstrdup() in security_get_bools() Rasmus Villemoes
2015-09-29 18:12 ` Stephen Smalley
2015-09-30 16:40 ` Paul Moore
2015-09-25 22:34 ` [PATCH 5/5] selinux: use sprintf return value Rasmus Villemoes
2015-09-29 18:17 ` Stephen Smalley
2015-09-30 15:00 ` Rasmus Villemoes
2015-09-30 16:43 ` Paul Moore
2015-09-29 17:59 ` [PATCH 0/5] selinux: minor cleanup suggestions Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443220459-11042-4-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome