From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbbI0SiO (ORCPT ); Sun, 27 Sep 2015 14:38:14 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:38286 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbbI0SiL (ORCPT ); Sun, 27 Sep 2015 14:38:11 -0400 From: Rabin Vincent To: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra CC: , Rabin Vincent Subject: [PATCH 4/5] tools: build: fix libiberty feature detection Date: Sun, 27 Sep 2015 20:37:58 +0200 Message-ID: <1443379079-29133-4-git-send-email-rabin.vincent@axis.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1443379079-29133-1-git-send-email-rabin.vincent@axis.com> References: <1443379079-29133-1-git-send-email-rabin.vincent@axis.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pass CFLAGS and LDFLAGS to the libiberty compile line to make the detection work when using a cross compiler. Otherwise perf fails to link even though BFD is detected. ... libbfd: [ on ] LINK perf libbfd.a(bfd.o): In function `bfd_errmsg': bfd.c:(.text+0x168): undefined reference to `xstrerror' bbfd.a(opncls.o): In function `_bfd_new_bfd': opncls.c:(.text+0xe8): undefined reference to `objalloc_create' ... Signed-off-by: Rabin Vincent --- tools/build/feature/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile index e43a297..cea04ce9 100644 --- a/tools/build/feature/Makefile +++ b/tools/build/feature/Makefile @@ -132,10 +132,10 @@ test-libbfd.bin: $(BUILD) -DPACKAGE='"perf"' -lbfd -lz -liberty -ldl test-liberty.bin: - $(CC) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' -lbfd -ldl -liberty + $(CC) $(CFLAGS) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty test-liberty-z.bin: - $(CC) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' -lbfd -ldl -liberty -lz + $(CC) $(CFLAGS) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty -lz test-cplus-demangle.bin: $(BUILD) -liberty -- 1.7.10.4