From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbbI1Aef (ORCPT ); Sun, 27 Sep 2015 20:34:35 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:36275 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbI1Aee (ORCPT ); Sun, 27 Sep 2015 20:34:34 -0400 Message-ID: <1443400461.2517.22.camel@decadent.org.uk> Subject: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop From: Ben Hutchings To: Maxim Levitsky , Roger Tseng Cc: LKML , Lee Jones Date: Mon, 28 Sep 2015 01:34:21 +0100 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-GVwcCRL/UIIPUCis9ixb" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-GVwcCRL/UIIPUCis9ixb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming. Change the sleep to be interruptible, but still ignore signals. A better fix might be to replace this loop with a delayed work item. References: https://bugs.debian.org/765717 Signed-off-by: Ben Hutchings --- --- a/drivers/memstick/host/rtsx_usb_ms.c +++ b/drivers/memstick/host/rtsx_usb_ms.c @@ -706,7 +706,8 @@ poll_again: if (host->eject) break; =20 - msleep(1000); + if (msleep_interruptible(1000)) + flush_signals(current); } =20 complete(&host->detect_ms_exit); --=20 Ben Hutchings All extremists should be taken out and shot. --=-GVwcCRL/UIIPUCis9ixb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVgiLDee/yOyVhhEJAQq/pRAAmWZrAD+WoxIyu1e866eiyeWkC/eFC6cs GgmXY+ZamicOeJq/bdYnrd8WKouZUnpPR4HA0GqdqB+99vTCK6+JIkHNqLgeOi56 FFKZC4MMpv3vHYXPe10OF381GYNJG1c5yccIr6jwNWeQMs6lgeWqXBUUwSZ9fF1q 1k8lmemTSER91U6NXC/Qt1c/WuMN/fhAREudfSAAfIAkdjD17Q92Y94cZYFYlEeI GR/TznmiUL6k9JK+/LyLlq+fLLLzUcfMHcYZjsoPRk8LTQ+hKefazD+qgP/KwC39 iuzDpio40SXyF840J6ot8EsHzCpwNMN8QZaFdyfccJiYH0C2y5BWpIenbie143LM Std3RjsIY+ikyO39KAzl7qNIntjqlQkQb+9WoqdIZcSRo+/nUXfxiQQkpBq4a3/I hl2fXMXow2FDmPWLK1DO6mAIhSHAMWPN5nHqhzMu6IWBOm6xP0cVmxR7i1KOybra cjTp+V51zoEBN/u65vYrQhFiDGmBelokh/elElIH9X/DZjPdrbIMR+j9PgX++mEU PmerfvHtmlJf5Wt4bcfNzq9L/fiUuzy0Ch67I8jv+ohaOvEySXR7RbIf0MccwQid 3y/RWXllUmjgo17kZhVQmKQM7O1yLbjw90ku44UGHPin1DHockxSB2hK+wWRnv4w 78d4GvHAf+c= =VEPM -----END PGP SIGNATURE----- --=-GVwcCRL/UIIPUCis9ixb--