From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756849AbbI1Iud (ORCPT ); Mon, 28 Sep 2015 04:50:33 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:25397 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045AbbI1Iub (ORCPT ); Mon, 28 Sep 2015 04:50:31 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-0f-5608ff54578e From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Rasesh Mody , netdev@vger.kernel.org (open list:BROCADE BNA 10 GIGABIT ETHERNET DRIVER) Subject: [PATCH] bna: fix error handling Date: Mon, 28 Sep 2015 10:49:48 +0200 Message-id: <1443430188-32702-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFJMWRmVeSWpSXmKPExsVy+t/xa7oh/znCDLbtVre4te4cq8XGGetZ LS7vmsNmsfbIXXaLYwvELPbuusDowOax7ssJdo++LasYPT5vkgtgjuKySUnNySxLLdK3S+DK mHjxGGPBI76KtiMNrA2MH7m7GDk5JARMJBZPX8sEYYtJXLi3nq2LkYtDSGApo8T19ROhnCYm ibWn3zKDVLEJaEr83XyTDcQWEVCQ2Nz7jBXEZhZoZpL4fqsGxBYW0JD4t3EVexcjBweLgKrE i03VICavgLPEhw/hELvkJE4em8w6gZF7ASPDKkbR1NLkguKk9FxDveLE3OLSvHS95PzcTYyQ EPiyg3HxMatDjAIcjEo8vDPUOcKEWBPLiitzDzFKcDArifD+/QEU4k1JrKxKLcqPLyrNSS0+ xCjNwaIkzjt31/sQIYH0xJLU7NTUgtQimCwTB6dUA2Me2z9FBRWzz5+U32reuvmtk3sp19I5 Cy72anRezyqcXGQkwDXLj0NN0sNqgXKB5fanPSHvbHukkp5K8UjcWmbOvW6542Q/yZoJy60X R0ycojY/tHVS52rzon37ztkXrXloe/2TouBav5wf7ap5z2ct0n3oXHRZ7rrErMob3mzZoWXd a17t267EUpyRaKjFXFScCADguBnw/QEAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Several functions can return negative value in case of error, so their return type should be fixed as well as type of variables to which this value is assigned. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index b7a0f78..9e59663 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -1543,7 +1543,7 @@ bfa_flash_cmd_act_check(void __iomem *pci_bar) } /* Flush FLI data fifo. */ -static u32 +static int bfa_flash_fifo_flush(void __iomem *pci_bar) { u32 i; @@ -1573,11 +1573,11 @@ bfa_flash_fifo_flush(void __iomem *pci_bar) } /* Read flash status. */ -static u32 +static int bfa_flash_status_read(void __iomem *pci_bar) { union bfa_flash_dev_status_reg dev_status; - u32 status; + int status; u32 ret_status; int i; @@ -1611,11 +1611,11 @@ bfa_flash_status_read(void __iomem *pci_bar) } /* Start flash read operation. */ -static u32 +static int bfa_flash_read_start(void __iomem *pci_bar, u32 offset, u32 len, char *buf) { - u32 status; + int status; /* len must be mutiple of 4 and not exceeding fifo size */ if (len == 0 || len > BFA_FLASH_FIFO_SIZE || (len & 0x03) != 0) @@ -1703,7 +1703,8 @@ static enum bfa_status bfa_flash_raw_read(void __iomem *pci_bar, u32 offset, char *buf, u32 len) { - u32 n, status; + u32 n; + int status; u32 off, l, s, residue, fifo_sz; residue = len; -- 1.9.1