From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756999AbbI1IwM (ORCPT ); Mon, 28 Sep 2015 04:52:12 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:31888 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755216AbbI1IwK (ORCPT ); Mon, 28 Sep 2015 04:52:10 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-26-5608ffb7e73e From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) Subject: [PATCH] fix handling bq27xxx_read result Date: Mon, 28 Sep 2015 10:51:27 +0200 Message-id: <1443430287-575-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42I5/e/4Fd3t/znCDGYeULG4te4cq8XGGetZ LSY9ec9sMXHlZGaLy7vmsFl87j3CaLH2yF12i4mnfzNZnN5d4sDpsXPWXXaPzSu0PDat6mTz 6NuyitHj8ya5ANYoLpuU1JzMstQifbsEroz1LeeZCp6wVUy9s4u9gfEJaxcjJ4eEgInE+2mT oWwxiQv31rOB2EICSxklbv836WLkArKbmCTWtVwHK2IT0JT4u/kmWJGIgILE5t5nrCBFzAIz mCUurXnHDJIQFjCUWHzrGCOIzSKgKjHnzDV2EJtXwFFicksXE8Q2OYmTxyazTmDkXsDIsIpR NLU0uaA4KT3XUK84Mbe4NC9dLzk/dxMjJGy+7GBcfMzqEKMAB6MSD+8MdY4wIdbEsuLK3EOM EhzMSiK8f38AhXhTEiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbLxMEp 1cBoteBDwtL7abPnPOBdeMzpo9GJNN7n/1mY1fbWHJ5V7S7r8lyG89mBxplbGUoVjI8emOVe +razxLRiSXJbeUZ8THPsPcnzU6XkmzK2LPCZbf7u279abqnMlq65xXURxe92b7t78EHO1uNc Suaqsj8zw3kVfM32L1QQ+FamMpnjot3+vzsX3lqoxFKckWioxVxUnAgAs/yK0BcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/power/bq27xxx_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c index 473aa2f..994c78d 100644 --- a/drivers/power/bq27xxx_battery.c +++ b/drivers/power/bq27xxx_battery.c @@ -691,7 +691,7 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags) */ static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di) { - u16 flags; + int flags; flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false); if (flags < 0) { -- 1.9.1