From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932822AbbI1LKP (ORCPT ); Mon, 28 Sep 2015 07:10:15 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:38357 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932533AbbI1LKO (ORCPT ); Mon, 28 Sep 2015 07:10:14 -0400 Message-ID: <1443438600.2517.33.camel@decadent.org.uk> Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop From: Ben Hutchings To: Lee Jones Cc: Maxim Levitsky , Roger Tseng , LKML Date: Mon, 28 Sep 2015 12:10:00 +0100 In-Reply-To: <20150928103444.GP27197@x1> References: <1443400461.2517.22.camel@decadent.org.uk> <20150928103444.GP27197@x1> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-gCBrSxlTuCgdSJRbUTod" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-gCBrSxlTuCgdSJRbUTod Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > The subsystem is missing from the subject line. >=20 > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > > bug-compatibility with Unix). A load average of ~1 on a system > > that > > should be idle is somewhat alarming. > >=20 > > Change the sleep to be interruptible, but still ignore signals. > >=20 > > A better fix might be to replace this loop with a delayed work > > item. > >=20 > > References: https://bugs.debian.org/765717 > > Signed-off-by: Ben Hutchings >=20 > How was this patch made? Where's the diff etc? With quilt. > Why was this patch sent to me? I think I must have added you previously as MFD maintainer, but as this doesn't touch rtsx_pcr or rtsx_usb it's not really in your area. Sorry to bother you. Ben. > > --- > > --- a/drivers/memstick/host/rtsx_usb_ms.c > > +++ b/drivers/memstick/host/rtsx_usb_ms.c > > @@ -706,7 +706,8 @@ poll_again: > > if (host->eject) > > break; > > =20 > > - msleep(1000); > > + if (msleep_interruptible(1000)) > > + flush_signals(current); > > } > > =20 > > complete(&host->detect_ms_exit); >=20 --=20 Ben Hutchings All extremists should be taken out and shot. --=-gCBrSxlTuCgdSJRbUTod Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVgkgCOe/yOyVhhEJAQoPRw/+N41qGFPaW6DYSectNqYPCWjekVds8qsq XWilvckePlm6jwcVCLVn1nLeaHsRhbdL6QdY75QNSgvMb+fwPny+TSEYh+65r3e3 lyA43Beccy0R0cuRie+33rgxbMRlK2EtfexduJaXuR2dSJgQGrwBdU/7XKRT+i8H SIk3QjnSe0K2XNJbXbMPRO5EuNEpwBnvBwg2Z0uOagvYoMZx6yChRhIvDqmaYq0g v5Q+iBMGekZj7Ya25Lqm9zUc5keKOMIvNzNxGqtqxpuckl4R1+ck7ryPvqXMBh1u KegFkWG89h8gEcPgzGrh4b4Y3PkeKmy0A9MOpjyTQLD92fWFvOaue6/qr34cHbra UxDpyVBFidY4WHIZ/qVCKshQMvYPsLtl7fmD4EHeHOoDvJF54ES6+YsLh26pDbeZ EhFSYzaJjI1ffQAJk/c4qQy+KSponw2Ka6b+CLdyUID34TI3Q0RseTC8Uz3Z4SfK pfh/enMo1eJ5bhuf+SruLB0/igKBHC0WupN1GuLph4uycIl8Kznpd6fX31k38eyN 3xcPJPZwKV3oTsUnZFJECzkGHCOZ1XtwqzTU0Nprb7fMpZluUqibzzxZd4L/YdJ3 5aa/BrUCEFlXB1OpW2pA3OD+Mj+3jGN34bb+zejyM6l5bb52SA8yE5QKyClDzYTK k00LBUbPESg= =036u -----END PGP SIGNATURE----- --=-gCBrSxlTuCgdSJRbUTod--