From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, sakari.ailus@linux.intel.com,
andrew@lunn.ch, rpurdie@rpsys.net,
Jacek Anaszewski <j.anaszewski@samsung.com>
Subject: [PATCH v2 00/12] LED core improvements
Date: Mon, 28 Sep 2015 15:07:09 +0200 [thread overview]
Message-ID: <1443445641-9529-1-git-send-email-j.anaszewski@samsung.com> (raw)
This is a second version of the patch set preparing the
ground for removing work queues from LED class drivers.
Andrew and Sakari - thanks for a review.
================
Changes from v1:
================
- removed useless use of else in led_set_brightness()
- switched to removing error code instead of emitting
warning from led_set_brightness_sync() in case software
blink fallback is enabled
- moved __led_set_brightness() contents to set_brightness_delayed()
- removed description of internal led_set_brightness_nosleep() from
led-class.txt documentation, and modified description of
led_set_brightness() and led_set_brightness_sync()
- renamed LED_BLINK_CHANGE flag to more meaningful
LED_BLINK_BRIGHTNESS_CHANGE
- Fixed stylistic issues in a few comments
- Adopted old brightness_set_sync() op description to
a new brightness_set_blocking() op
- Fixed led_set_brightness_nosleep to avoid scheduling
spurious set_brightness_work
- made LED core using EXPORT_SYMBOL_GPL consistently
- switched v4l2-flash-led-class wrapper to using
led_set_brightness_sync API for setting torch brightness
- merged with patch set
"LED flash: Set brightness in a sync way on demand"
======================
Original cover letter:
======================
This patch set prepares the ground for removing work queues
from LED class drivers, and is a follow up of the patch set [1].
LED core modifications have been reorganized to make them
more clear and easier to review. The patch set is reduced
in comparison to it its predecessor, to expose the modifications
indispensable for the LED core to gain the capability of handling
brightness_set_blocking ops, that is without work queues.
Thanks,
Jacek Anaszewski
[1] https://lkml.org/lkml/2015/8/20/426
Jacek Anaszewski (12):
leds: core: Use EXPORT_SYMBOL_GPL consistently
leds: core: Move LED core callbacks out of led-class.c
leds: core: Add two new LED_BLINK_ flags
leds: Rename brightness_set_sync op to brightness_set_blocking
leds: core: Add an internal led_set_brightness_nosleep function
leds: core: Use set_brightness_work for the blocking op
leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting
Documentation: leds: Add description of brightness setting API
leds: max77693: Remove work queue
leds: aat1290: Remove work queue
leds: ktd2692: Remove work queue
media: flash: use led_set_brightness_sync for torch brightness
Documentation/leds/leds-class.txt | 13 ++
drivers/leds/led-class-flash.c | 6 +-
drivers/leds/led-class.c | 71 +---------
drivers/leds/led-core.c | 166 +++++++++++++++++++++---
drivers/leds/leds-aat1290.c | 50 ++-----
drivers/leds/leds-ktd2692.c | 41 +-----
drivers/leds/leds-max77693.c | 57 ++------
drivers/leds/leds.h | 26 +---
drivers/leds/trigger/ledtrig-backlight.c | 8 +-
drivers/leds/trigger/ledtrig-default-on.c | 2 +-
drivers/leds/trigger/ledtrig-gpio.c | 6 +-
drivers/leds/trigger/ledtrig-heartbeat.c | 4 +-
drivers/leds/trigger/ledtrig-oneshot.c | 4 +-
drivers/leds/trigger/ledtrig-transient.c | 8 +-
drivers/media/v4l2-core/v4l2-flash-led-class.c | 8 +-
include/linux/leds.h | 27 +++-
16 files changed, 233 insertions(+), 264 deletions(-)
--
1.7.9.5
next reply other threads:[~2015-09-28 13:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 13:07 Jacek Anaszewski [this message]
2015-09-28 13:07 ` [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently Jacek Anaszewski
2015-09-28 15:13 ` Jacek Anaszewski
2015-10-08 15:51 ` Pavel Machek
2015-10-09 8:19 ` Jacek Anaszewski
2015-10-09 11:17 ` Pavel Machek
2015-09-28 13:07 ` [PATCH v2 02/12] leds: core: Move LED core callbacks out of led-class.c Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 03/12] leds: core: Add two new LED_BLINK_ flags Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 04/12] leds: Rename brightness_set_sync op to brightness_set_blocking Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 05/12] leds: core: Add an internal led_set_brightness_nosleep function Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 06/12] leds: core: Use set_brightness_work for the blocking op Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 07/12] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 08/12] Documentation: leds: Add description of brightness setting API Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 09/12] leds: max77693: Remove work queue Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 10/12] leds: aat1290: " Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 11/12] leds: ktd2692: " Jacek Anaszewski
2015-09-28 13:07 ` [PATCH v2 12/12] media: flash: use led_set_brightness_sync for torch brightness Jacek Anaszewski
2015-09-28 20:37 ` Pavel Machek
2015-09-29 7:26 ` Jacek Anaszewski
2015-09-29 9:39 ` Pavel Machek
2015-10-01 13:22 ` [PATCH v2 00/12] LED core improvements Sakari Ailus
2015-10-01 13:55 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443445641-9529-1-git-send-email-j.anaszewski@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®