From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933979AbbI1NxA (ORCPT ); Mon, 28 Sep 2015 09:53:00 -0400 Received: from m12-15.163.com ([220.181.12.15]:46840 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933933AbbI1Nwy (ORCPT ); Mon, 28 Sep 2015 09:52:54 -0400 From: Yaowei Bai To: viro@zeniv.linux.org.uk, tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 21:50:37 +0800 Message-Id: <1443448237-5285-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> X-CM-TRANSID: D8CowECZl1skRglW6XZBBg--.41417S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxU33C7DUUUU X-Originating-IP: [58.209.166.48] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiuwiDT1O-wU1BFwAAsJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/ext4/namei.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 9f61e76..41b6cc8 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2469,9 +2469,6 @@ static int ext4_mknod(struct inode *dir, struct dentry *dentry, struct inode *inode; int err, credits, retries = 0; - if (!new_valid_dev(rdev)) - return -EINVAL; - err = dquot_initialize(dir); if (err) return err; -- 1.9.1