From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934013AbbI1Oep (ORCPT ); Mon, 28 Sep 2015 10:34:45 -0400 Received: from m12-18.163.com ([220.181.12.18]:52426 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757039AbbI1Oeo (ORCPT ); Mon, 28 Sep 2015 10:34:44 -0400 From: Yaowei Bai To: viro@zeniv.linux.org.uk, mikulas@artax.karlin.mff.cuni.cz Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 22:11:19 +0800 Message-Id: <1443449479-5379-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> X-CM-TRANSID: EsCowECZIFsASwlWAGtKAw--.34582S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKrWUury3tFyUGw15try5Arb_yoW3Gwb_Cr Wjyr48uwsrJw1fJws8G3yaqr13Kan0yrn3K34vqw12qFWjv395ZFyqgws0y3yUWw45WFWU ur97CFy3ur98ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8JCzJUUUUU== X-Originating-IP: [58.209.166.48] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiKxSDT1QG9Wqj6QABs1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/hpfs/namei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 9e92c9c..ae4d5a1 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c @@ -227,8 +227,6 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, de int err; if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; - if (!new_valid_dev(rdev)) - return -EINVAL; hpfs_lock(dir->i_sb); err = -ENOSPC; fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); -- 1.9.1