From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934095AbbI1OaY (ORCPT ); Mon, 28 Sep 2015 10:30:24 -0400 Received: from m12-16.163.com ([220.181.12.16]:59091 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933318AbbI1OaW (ORCPT ); Mon, 28 Sep 2015 10:30:22 -0400 From: Yaowei Bai To: viro@zeniv.linux.org.uk, petr@vandrovec.name, jack@suse.cz, axboe@fb.com, akpm@linux-foundation.org, tj@kernel.org, fabf@skynet.be, dhowells@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/17] fs/ncpfs: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 22:25:46 +0800 Message-Id: <1443450346-5601-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> X-CM-TRANSID: EMCowECp+kBiTglWDdGWCQ--.46153S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKrWUury3tFyUGw15uFyrCrg_yoWxCFc_WF 4vyay0qr4Iqw15AwsxGrsIvr9IvF43tr1fCa4rtw1UCa40yayDArn8AFs8ZFZrWw4DCry7 WryUCrZxCry5CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0zHq3UUUUU== X-Originating-IP: [58.209.166.48] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiKwSDT1QG9Wr8aAAAs6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/ncpfs/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 93575e9..2d9891a 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c @@ -1165,8 +1165,6 @@ out: static int ncp_mknod(struct inode * dir, struct dentry *dentry, umode_t mode, dev_t rdev) { - if (!new_valid_dev(rdev)) - return -EINVAL; if (ncp_is_nfs_extras(NCP_SERVER(dir), NCP_FINFO(dir)->volNumber)) { ncp_dbg(1, "mode = 0%ho\n", mode); return ncp_create_new(dir, dentry, mode, rdev, 0); -- 1.9.1