From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934085AbbI1OgE (ORCPT ); Mon, 28 Sep 2015 10:36:04 -0400 Received: from m12-16.163.com ([220.181.12.16]:44122 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933794AbbI1OgA (ORCPT ); Mon, 28 Sep 2015 10:36:00 -0400 From: Yaowei Bai To: viro@zeniv.linux.org.uk, konishi.ryusuke@lab.ntt.co.jp Cc: linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/17] fs/nilfs2: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 22:33:43 +0800 Message-Id: <1443450823-5692-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> X-CM-TRANSID: EMCowECJK0c_UAlWxjOXCQ--.45969S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrCrWfKw1fJFyDtFyfuF4UArb_yoWxGwb_Gr yvyr48WFyIqw43Jws5Gry3GrykJ3ZYka4rJa4YyF1qvF1qyrZ5ZFWDWFsayFyUWr4kXrnI 9r9rCF98Wr15GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0nFx5UUUUU== X-Originating-IP: [58.209.166.48] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiUAKDT1WBQU1VEwAAsA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/nilfs2/namei.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 37dd6b0..c9a1a49 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c @@ -120,9 +120,6 @@ nilfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev) struct nilfs_transaction_info ti; int err; - if (!new_valid_dev(rdev)) - return -EINVAL; - err = nilfs_transaction_begin(dir->i_sb, &ti, 1); if (err) return err; -- 1.9.1