From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934231AbbI1Ow3 (ORCPT ); Mon, 28 Sep 2015 10:52:29 -0400 Received: from m12-12.163.com ([220.181.12.12]:41070 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933975AbbI1OwX (ORCPT ); Mon, 28 Sep 2015 10:52:23 -0400 From: Yaowei Bai To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/17] fs/stat: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 22:50:14 +0800 Message-Id: <1443451814-5785-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> X-CM-TRANSID: DMCowEDZgFIeVAlWcKIqBg--.218S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKrWUury3tFyUGw1rJFWxtFb_yoWxtFX_Cr yIy3y8Wr47Jr1Skw4fWws5Zry5Gwnagan3Ka43tF1Fyw42vrs8AryDWFs8J3y5u3sxXFyD GrsrKry7Wr15CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8wvKUUUUUU== X-Originating-IP: [58.209.166.48] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/1tbiLR+DT1SIKf2B6AAAsf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/stat.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/stat.c b/fs/stat.c index cccc1aa..d4a61d8 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -367,8 +367,6 @@ static long cp_new_stat64(struct kstat *stat, struct stat64 __user *statbuf) INIT_STRUCT_STAT64_PADDING(tmp); #ifdef CONFIG_MIPS /* mips has weird padding, so we don't get 64 bits there */ - if (!new_valid_dev(stat->dev) || !new_valid_dev(stat->rdev)) - return -EOVERFLOW; tmp.st_dev = new_encode_dev(stat->dev); tmp.st_rdev = new_encode_dev(stat->rdev); #else -- 1.9.1