From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753126AbbI1Uyx (ORCPT ); Mon, 28 Sep 2015 16:54:53 -0400 Received: from lists.s-osg.org ([54.187.51.154]:39718 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbbI1Uyw (ORCPT ); Mon, 28 Sep 2015 16:54:52 -0400 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org, surya.seetharaman9@gmail.com, devel@driverdev.osuosl.org, Luis de Bethencourt Subject: [PATCH] staging: comedi: ni_tiocmd: remove unused code Date: Mon, 28 Sep 2015 21:54:45 +0100 Message-Id: <1443473685-3689-1-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the unused code, which isn't implemented yet, using #if 0. Signed-off-by: Luis de Bethencourt --- Hi, The code after the return is dead code. My understanding is that it is there for when the output commands are implemented in the future. Meanwhile it would be clearer if the code is removed with #if 0. Thanks, Luis drivers/staging/comedi/drivers/ni_tiocmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c index 9b124b0..728c7f4 100644 --- a/drivers/staging/comedi/drivers/ni_tiocmd.c +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c @@ -158,11 +158,13 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s) "output commands not yet implemented.\n"); return -ENOTSUPP; +#if 0 /* unused */ counter->mite_chan->dir = COMEDI_OUTPUT; mite_prep_dma(counter->mite_chan, 32, 32); ni_tio_configure_dma(counter, true, false); mite_dma_arm(counter->mite_chan); return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE); +#endif } static int ni_tio_cmd_setup(struct comedi_subdevice *s) -- 2.5.1