mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	gregkh@linuxfoundation.org, amaury.denoyelle@gmail.com,
	devel@driverdev.osuosl.org,
	Luis de Bethencourt <luisbg@osg.samsung.com>
Subject: [PATCH] staging: comedi: cb_pcidas64: remove unused code
Date: Mon, 28 Sep 2015 22:10:42 +0100	[thread overview]
Message-ID: <1443474642-9965-1-git-send-email-luisbg@osg.samsung.com> (raw)
In-Reply-To: <1443473685-3689-1-git-send-email-luisbg@osg.samsung.com>

Remove the disabled code, for now, with #if 0.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

The code after the return is dead code. There is a comment saying it is
disabled for now, it would be good if the code is removed with #if 0 as
well.

Thanks,
Luis

 drivers/staging/comedi/drivers/cb_pcidas64.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index d33b8fe..f86ea9f 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -2233,10 +2233,12 @@ static int use_hw_sample_counter(struct comedi_cmd *cmd)
 /* disable for now until I work out a race */
 	return 0;
 
+#if 0
 	if (cmd->stop_src == TRIG_COUNT && cmd->stop_arg <= max_counter_value)
 		return 1;
 
 	return 0;
+#endif
 }
 
 static void setup_sample_counters(struct comedi_device *dev,
-- 
2.5.1


  reply	other threads:[~2015-09-28 21:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 20:54 [PATCH] staging: comedi: ni_tiocmd: " Luis de Bethencourt
2015-09-28 21:10 ` Luis de Bethencourt [this message]
2015-09-29  1:23   ` [PATCH] staging: comedi: cb_pcidas64: " Greg KH
2015-09-29  9:55     ` Luis de Bethencourt
2015-09-28 21:52 ` [PATCH] staging: rtl8712: remove dead code Luis de Bethencourt
2015-09-30  5:32   ` Joshua Clayton
2015-09-29  1:22 ` [PATCH] staging: comedi: ni_tiocmd: remove unused code Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443474642-9965-1-git-send-email-luisbg@osg.samsung.com \
    --to=luisbg@osg.samsung.com \
    --cc=abbotti@mev.co.uk \
    --cc=amaury.denoyelle@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®