From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234AbbI1W3S (ORCPT ); Mon, 28 Sep 2015 18:29:18 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:34356 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbbI1W3Q (ORCPT ); Mon, 28 Sep 2015 18:29:16 -0400 From: Rasmus Villemoes To: Mark Brown , Greg Kroah-Hartman Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] regmap: debugfs: remove bogus check Date: Tue, 29 Sep 2015 00:29:01 +0200 Message-Id: <1443479342-31621-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org snprintf cannot return a negative value (unless map->dev->driver->name happens to be over 2G long). So remove the bogus check. Signed-off-by: Rasmus Villemoes --- drivers/base/regmap/regmap-debugfs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index 4a4737887cce..9fb3f6fc26b0 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -48,10 +48,6 @@ static ssize_t regmap_name_read_file(struct file *file, return -ENOMEM; ret = snprintf(buf, PAGE_SIZE, "%s\n", map->dev->driver->name); - if (ret < 0) { - kfree(buf); - return ret; - } ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret); kfree(buf); -- 2.1.3