From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934349AbbI2J56 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 05:57:58 -0400
Received: from ozlabs.org ([103.22.144.67]:46142 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933654AbbI2J5s (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 05:57:48 -0400
Message-ID: <1443520665.11041.1.camel@ellerman.id.au>
Subject: Re: [PATCH] kselftest: replace $(RM) with rm -f command
From: Michael Ellerman <mpe@ellerman.id.au>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Wang Long <long.wanglong@huawei.com>, shuahkh@osg.samsung.com,
        dvhart@infradead.org, keescook@chromium.org, davem@davemloft.net,
        luto@amacapital.net, wad@chromium.org,
        Andrew Morton <akpm@linux-foundation.org>, gorcunov@openvz.org,
        cov@codeaurora.org, bobby prani <bobby.prani@gmail.com>,
        tyler baker <tyler.baker@linaro.org>,
        Tim Bird <tim.bird@sonymobile.com>, josh@joshtriplett.org,
        Andrea Arcangeli <aarcange@redhat.com>,
        andrej skvortzov <andrej.skvortzov@gmail.com>, sjayaram@akamai.com,
        treding@nvidia.com, Ingo Molnar <mingo@kernel.org>,
        naresh kamboju <naresh.kamboju@linaro.org>,
        alexey kodanev <alexey.kodanev@oracle.com>,
        linux-api <linux-api@vger.kernel.org>, linux-kernel@vger.kernel.org,
        wanglong@laoqinren.net
Date: Tue, 29 Sep 2015 19:57:45 +1000
In-Reply-To: <1201012824.5792.1443410213729.JavaMail.zimbra@efficios.com>
References: <20150925154415.GC38748@vmdeb7>
	 <1443406217-137773-1-git-send-email-long.wanglong@huawei.com>
	 <1201012824.5792.1443410213729.JavaMail.zimbra@efficios.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2015-09-28 at 03:16 +0000, Mathieu Desnoyers wrote:
> ----- On Sep 27, 2015, at 10:10 PM, Wang Long long.wanglong@huawei.com wrote:
> 
> > Some test's Makefile using "$(RM)" while the other's
> > using "rm -f". It is better to use one of them in all
> > tests.
> 
> I agree that this disparity appears to be unwanted. We
> should settle on one or the other.
> 
> > "rm -f" is better, because it is less magic, and everyone
> > konws what is does.
> 
> "$(RM)" is clearly defined as a Makefile implicit variable
> which defaults to "rm -f".
> Ref. https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

Sure, but you had to look it up didn't you :) - I did.

> Leaving it as a variable is more flexible because then the
> default behavior can be overridden if need be, which is
> not the case of a hardcoded "rm -f".

But I don't think anyone actually wants to do that. Do they?

Anyway I don't really care either way, so I'm happy for you to do a patch that
uses $(RM). Or maybe Wang Long will be happy to respin his patch to use $(RM).

cheers