From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Support Opensource <support.opensource@diasemi.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCH 7/8] mfd: da9052: Simplify function return logic
Date: Tue, 29 Sep 2015 13:26:07 +0200 [thread overview]
Message-ID: <1443525968-30899-8-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1443525968-30899-1-git-send-email-javier@osg.samsung.com>
The invoked functions already return zero on success or a negative
errno code so there is no need to open code the logic in the caller.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/da9052-i2c.c | 6 +-----
drivers/mfd/da9052-spi.c | 6 +-----
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index 02887001e800..2697ffb08009 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -174,11 +174,7 @@ static int da9052_i2c_probe(struct i2c_client *client,
return ret;
}
- ret = da9052_device_init(da9052, id->driver_data);
- if (ret != 0)
- return ret;
-
- return 0;
+ return da9052_device_init(da9052, id->driver_data);
}
static int da9052_i2c_remove(struct i2c_client *client)
diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index b5de8a6856c0..0f5e2c2858c1 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -56,11 +56,7 @@ static int da9052_spi_probe(struct spi_device *spi)
return ret;
}
- ret = da9052_device_init(da9052, id->driver_data);
- if (ret != 0)
- return ret;
-
- return 0;
+ return da9052_device_init(da9052, id->driver_data);
}
static int da9052_spi_remove(struct spi_device *spi)
--
2.4.3
next prev parent reply other threads:[~2015-09-29 11:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 11:26 [PATCH 0/8] mfd: Simplify " Javier Martinez Canillas
2015-09-29 11:26 ` [PATCH 1/8] mfd: htc-i2cpld: Remove unneded ret variable Javier Martinez Canillas
2015-10-01 7:17 ` Lee Jones
2015-09-29 11:26 ` [PATCH 2/8] mfd: arizona: " Javier Martinez Canillas
2015-09-29 11:24 ` Charles Keepax
2015-10-01 7:18 ` Lee Jones
2015-09-29 11:26 ` [PATCH 3/8] mfd: pcf50633: " Javier Martinez Canillas
2015-10-01 7:18 ` Lee Jones
2015-09-29 11:26 ` [PATCH 4/8] mfd: kempld-core: Simplify function return logic Javier Martinez Canillas
2015-10-01 7:19 ` Lee Jones
2015-09-29 11:26 ` [PATCH 5/8] mfd: rtsx: " Javier Martinez Canillas
2015-10-01 7:19 ` Lee Jones
2015-09-29 11:26 ` [PATCH 6/8] mfd: da903x: " Javier Martinez Canillas
2015-09-29 12:24 ` Opensource [Adam Thomson]
2015-10-01 7:20 ` Lee Jones
2015-09-29 11:26 ` Javier Martinez Canillas [this message]
2015-09-29 12:24 ` [PATCH 7/8] mfd: da9052: " Opensource [Adam Thomson]
2015-10-01 7:20 ` Lee Jones
2015-09-29 11:26 ` [PATCH 8/8] mfd: lm3533: " Javier Martinez Canillas
2015-09-30 21:04 ` Johan Hovold
2015-09-30 21:41 ` Javier Martinez Canillas
2015-09-30 21:55 ` Johan Hovold
2015-10-01 7:17 ` Lee Jones
2015-10-01 17:59 ` Johan Hovold
2015-10-01 7:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443525968-30899-8-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®