From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Chen <Peter.Chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
"Felipe F. Tonello" <eu@felipetonello.com>
Subject: [PATCH v3 2/4] usb: gadget: f_midi: free request when usb_ep_queue fails
Date: Tue, 29 Sep 2015 13:01:57 +0100 [thread overview]
Message-ID: <1443528119-31830-3-git-send-email-eu@felipetonello.com> (raw)
In-Reply-To: <1443528119-31830-1-git-send-email-eu@felipetonello.com>
This fix a memory leak that will occur in this case.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
drivers/usb/gadget/function/f_midi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 93212ca..163c0ce 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -546,9 +546,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
int err;
err = usb_ep_queue(ep, req, GFP_ATOMIC);
- if (err < 0)
+ if (err < 0) {
ERROR(midi, "%s queue req: %d\n",
midi->in_ep->name, err);
+ free_ep_req(ep, req);
+ }
} else {
free_ep_req(ep, req);
}
--
2.1.4
next prev parent reply other threads:[~2015-09-29 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 12:01 [PATCH v3 0/4] USB MIDI Gadget bug fixes and improvements Felipe F. Tonello
2015-09-29 12:01 ` [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done Felipe F. Tonello
2015-09-29 12:01 ` Felipe F. Tonello [this message]
2015-09-29 12:01 ` [PATCH v3 3/4] usb: gadget: f_midi: Transmit data only when IN ep is enabled Felipe F. Tonello
2015-09-29 12:01 ` [PATCH v3 4/4] usb: gadget: f_midi: remove duplicated code Felipe F. Tonello
2015-10-08 8:36 ` [PATCH v3 0/4] USB MIDI Gadget bug fixes and improvements Felipe Tonello
2015-10-09 9:23 ` [PATCH v3 1/4] usb: gadget: f_midi: free usb request when done Clemens Ladisch
2015-10-09 20:55 ` Felipe Balbi
2015-10-11 19:08 ` Clemens Ladisch
2015-10-12 10:11 ` Felipe Tonello
2015-10-12 9:46 ` Felipe Tonello
2015-10-12 10:16 ` Clemens Ladisch
2015-10-12 11:58 ` Felipe Tonello
2015-10-12 12:10 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443528119-31830-3-git-send-email-eu@felipetonello.com \
--to=eu@felipetonello.com \
--cc=Peter.Chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®