From: Jani Nikula <jani.nikula@intel.com>
To: "Huang Ying" <ying.huang@linux.intel.com>,
Jani Nikula <jani.nikula@intel.com>
Cc: kernel test robot <ying.huang@intel.com>,
lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
Clint Taylor <Clinton.A.Taylor@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH] drm/i915: disable CPU PWM also on LPT/SPT backlight disable
Date: Tue, 29 Sep 2015 15:41:48 +0300 [thread overview]
Message-ID: <1443530508-12112-1-git-send-email-jani.nikula@intel.com> (raw)
In-Reply-To: <87y4fpmyqi.fsf@yhuang-dev.intel.com>
Although we don't support or enable CPU PWM with LPT/SPT based systems,
it may have been enabled prior to loading the driver. Disable the CPU
PWM on LPT/SPT backlight disable to avoid warnings on LCPLL disable.
The issue has been present on BDW since BDW enabling, but was recently
introduced on HSW with
commit 437b15b8017e0d946453c10794b0c5d4591cf180
Author: Jani Nikula <jani.nikula@intel.com>
Date: Fri Sep 4 16:55:13 2015 +0300
drm/i915: use pch backlight override on hsw too
Reference: http://mid.gmane.org/87y4frhwsn.fsf@yhuang-dev.intel.com
Reported-by: kernel test robot <ying.huang@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_panel.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index dd71e7f139e3..c9c94d05f3dd 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -731,6 +731,20 @@ static void lpt_disable_backlight(struct intel_connector *connector)
intel_panel_actually_set_backlight(connector, 0);
+ /*
+ * Although we don't support or enable CPU PWM with LPT/SPT based
+ * systems, it may have been enabled prior to loading the
+ * driver. Disable to avoid warnings on LCPLL disable.
+ *
+ * This needs rework if we need to add support for CPU PWM on PCH split
+ * platforms.
+ */
+ tmp = I915_READ(BLC_PWM_CPU_CTL2);
+ if (tmp & BLM_PWM_ENABLE) {
+ DRM_DEBUG_KMS("cpu backlight was enabled, disabling\n");
+ I915_WRITE(BLC_PWM_CPU_CTL2, tmp & ~BLM_PWM_ENABLE);
+ }
+
tmp = I915_READ(BLC_PWM_PCH_CTL1);
I915_WRITE(BLC_PWM_PCH_CTL1, tmp & ~BLM_PCH_PWM_ENABLE);
}
--
2.1.4
next prev parent reply other threads:[~2015-09-29 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 6:39 [lkp] [drm/i915] 437b15b801: [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)! kernel test robot
2015-09-28 7:32 ` Jani Nikula
2015-09-29 8:11 ` Huang, Ying
2015-09-29 12:41 ` Jani Nikula [this message]
2015-09-29 12:49 ` [PATCH] drm/i915: disable CPU PWM also on LPT/SPT backlight disable Jani Nikula
2015-10-08 13:44 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443530508-12112-1-git-send-email-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=Clinton.A.Taylor@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=ying.huang@intel.com \
--cc=ying.huang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome