From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932949AbbI3KWF (ORCPT ); Wed, 30 Sep 2015 06:22:05 -0400 Received: from lists.s-osg.org ([54.187.51.154]:40082 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932600AbbI3Jwf (ORCPT ); Wed, 30 Sep 2015 05:52:35 -0400 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: jikos@kernel.com, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, Luis de Bethencourt Subject: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect() Date: Wed, 30 Sep 2015 10:52:29 +0100 Message-Id: <1443606749-6028-1-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Since the error number is propagated, the caller will get a -EPERM which is the wrong error condition. Also, the smatch tool complains with the following warning: hiddev_connect() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt --- drivers/hid/usbhid/hiddev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 2f1ddca..c5290ff 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -894,7 +894,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force) } if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL))) - return -1; + return -ENOMEM; init_waitqueue_head(&hiddev->wait); INIT_LIST_HEAD(&hiddev->list); -- 2.5.1