From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbbI3Nvo (ORCPT ); Wed, 30 Sep 2015 09:51:44 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37329 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbbI3Nvl (ORCPT ); Wed, 30 Sep 2015 09:51:41 -0400 Message-ID: <1443621086.2412.11.camel@linaro.org> Subject: Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support From: "Ivan T. Ivanov" To: Mark Rutland Cc: Andy Gross , David Brown , Srinivas Kandagatla , Greg Kroah-Hartman , Jiri Slaby , Frank Rowand , Rob Herring , Pawel Moll , Ian Campbell , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-soc@vger.kernel.org" , "linux-serial@vger.kernel.org" Date: Wed, 30 Sep 2015 16:51:26 +0300 In-Reply-To: <20150930132919.GI10997@leverpostej> References: <1443614906-2196-1-git-send-email-ivan.ivanov@linaro.org> <1443614906-2196-5-git-send-email-ivan.ivanov@linaro.org> <20150930132919.GI10997@leverpostej> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-30 at 14:29 +0100, Mark Rutland wrote: > On Wed, Sep 30, 2015 at 01:08:24PM +0100, Ivan T. Ivanov wrote: > > Add transmit DMA support for UARTDM type of controllers. > > > > Tested on APQ8064, which have UARTDM v1.3 and ADM DMA engine > > and APQ8016, which have UARTDM v1.4 and BAM DMA engine. > > > > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org> > > --- > > .../devicetree/bindings/serial/qcom,msm-uartdm.txt | 3 + > > drivers/tty/serial/msm_serial.c | 312 +++++++++++++++++++-- > > drivers/tty/serial/msm_serial.h | 3 + > > 3 files changed, 294 insertions(+), 24 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt > > index a2114c217376..a600023d9ec1 100644 > > --- a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt > > +++ b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt > > @@ -26,6 +26,9 @@ Required properties: > > Optional properties: > > - dmas: Should contain dma specifiers for transmit and receive channels > > - dma-names: Should contain "tx" for transmit and "rx" for receive channels > > +- qcom,tx-crci: Identificator for Client Rate Control Interface to be > > + used with TX DMA channel. Required when using DMA for transmission > > + with UARTDM v1.3 and bellow. > > This sounds like it belongs in the dma-specifier, and dealt with by the > DMA controller driver. > > Why does the UART driver need to know about this? CRCI information was part of the first version of ADM DMA engine driver bindings, but Andy remove it because some client devices are requiring more that one CRCI number. See here[1] and here [2]. Regards, Ivan [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/314190.html [2] https://lkml.org/lkml/2015/8/19/19