mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"Liang, Kan" <kan.liang@intel.com>
Subject: [PATCH 31/45] perf stat report: Add report command
Date: Wed, 30 Sep 2015 16:10:44 +0200	[thread overview]
Message-ID: <1443622258-17158-32-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1443622258-17158-1-git-send-email-jolsa@kernel.org>

Adding 'perf stat report' command support. ATM it only
processes attr events and display nothing.

Link: http://lkml.kernel.org/n/tip-a43rs4c6szofeuo2gjlcpm0h@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/Documentation/perf-stat.txt | 12 +++++++
 tools/perf/builtin-stat.c              | 61 +++++++++++++++++++++++++++++++---
 tools/perf/util/session.c              |  3 ++
 3 files changed, 72 insertions(+), 4 deletions(-)

diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
index 0ccce466ad53..709c9ed165b2 100644
--- a/tools/perf/Documentation/perf-stat.txt
+++ b/tools/perf/Documentation/perf-stat.txt
@@ -11,6 +11,7 @@ SYNOPSIS
 'perf stat' [-e <EVENT> | --event=EVENT] [-a] <command>
 'perf stat' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
 'perf stat' [-e <EVENT> | --event=EVENT] [-a] record [-o file] -- <command> [<options>]
+'perf stat' report [-i file]
 
 DESCRIPTION
 -----------
@@ -26,6 +27,9 @@ OPTIONS
 record::
 	See STAT RECORD.
 
+report::
+	See STAT REPORT.
+
 -e::
 --event=::
 	Select the PMU event. Selection can be:
@@ -169,6 +173,14 @@ Stores stat data into perf data file.
 --output file::
 Output file name.
 
+STAT REPORT
+-----------
+Reads and reports stat data from perf data file.
+
+-i file::
+--input file::
+Input file name.
+
 
 EXAMPLES
 --------
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index b5297b9a27d5..4861fd639b7e 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -60,6 +60,8 @@
 #include "util/thread_map.h"
 #include "util/counts.h"
 #include "util/session.h"
+#include "util/tool.h"
+#include "asm/bug.h"
 
 #include <stdlib.h>
 #include <sys/prctl.h>
@@ -129,6 +131,7 @@ struct perf_stat {
 	struct perf_data_file	 file;
 	struct perf_session	*session;
 	u64			 bytes_written;
+	struct perf_tool	 tool;
 };
 
 static struct perf_stat		perf_stat;
@@ -977,8 +980,8 @@ static void print_header(int argc, const char **argv)
 		else if (target.cpu_list)
 			fprintf(output, "\'CPU(s) %s", target.cpu_list);
 		else if (!target__has_task(&target)) {
-			fprintf(output, "\'%s", argv[0]);
-			for (i = 1; i < argc; i++)
+			fprintf(output, "\'%s", argv ? argv[0] : "pipe");
+			for (i = 1; argv && (i < argc); i++)
 				fprintf(output, " %s", argv[i]);
 		} else if (target.pid)
 			fprintf(output, "process id \'%s", target.pid);
@@ -1396,6 +1399,55 @@ static int __cmd_record(int argc, const char **argv)
 	return argc;
 }
 
+static const char * const report_usage[] = {
+	"perf stat report [<options>]",
+	NULL,
+};
+
+static struct perf_stat perf_stat = {
+	.tool = {
+		.attr		= perf_event__process_attr,
+	},
+};
+
+static int __cmd_report(int argc, const char **argv)
+{
+	struct perf_session *session;
+	const struct option options[] = {
+	OPT_STRING('i', "input", &input_name, "file", "input file name"),
+	OPT_END()
+	};
+	struct stat st;
+	int ret;
+
+	argc = parse_options(argc, argv, options, report_usage, 0);
+
+	if (!input_name || !strlen(input_name)) {
+		if (!fstat(STDIN_FILENO, &st) && S_ISFIFO(st.st_mode))
+			input_name = "-";
+		else
+			input_name = "perf.data";
+	}
+
+	perf_stat.file.path = input_name;
+	perf_stat.file.mode = PERF_DATA_MODE_READ;
+
+	session = perf_session__new(&perf_stat.file, false, &perf_stat.tool);
+	if (session == NULL)
+		return -1;
+
+	perf_stat.session  = session;
+	stat_config.output = stderr;
+	evsel_list         = session->evlist;
+
+	ret = perf_session__process_events(session);
+	if (ret)
+		return ret;
+
+	perf_session__delete(session);
+	return 0;
+}
+
 int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
 {
 	bool append_file = false;
@@ -1469,7 +1521,7 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
 	const char *mode;
 	FILE *output = stderr;
 	unsigned int interval;
-	const char * const stat_subcommands[] = { "record" };
+	const char * const stat_subcommands[] = { "record", "report" };
 
 	setlocale(LC_ALL, "");
 
@@ -1485,7 +1537,8 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
 		argc = __cmd_record(argc, argv);
 		if (argc < 0)
 			return -1;
-	}
+	} else if (argc && !strncmp(argv[0], "rep", 3))
+		return __cmd_report(argc, argv);
 
 	interval = stat_config.interval;
 
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 5fc1631c676e..5b16a70f781d 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -36,6 +36,9 @@ static int perf_session__open(struct perf_session *session)
 	if (perf_data_file__is_pipe(file))
 		return 0;
 
+	if (perf_header__has_feat(&session->header, HEADER_STAT))
+		return 0;
+
 	if (!perf_evlist__valid_sample_type(session->evlist)) {
 		pr_err("non matching sample_type");
 		return -1;
-- 
2.4.3


  parent reply	other threads:[~2015-09-30 14:17 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 14:10 [PATCHv2 00/45] perf stat: Add scripting support Jiri Olsa
2015-09-30 14:10 ` [PATCH 01/45] perf tools: Add thread_map event Jiri Olsa
2015-09-30 14:10 ` [PATCH 02/45] perf tools: Add thread_map event synthesize function Jiri Olsa
2015-09-30 14:10 ` [PATCH 03/45] perf tools: Add thread_map__new_event function Jiri Olsa
2015-09-30 14:10 ` [PATCH 04/45] perf tools: Add cpu_map event Jiri Olsa
2015-09-30 14:10 ` [PATCH 05/45] perf tools: Add cpu_map event synthesize function Jiri Olsa
2015-09-30 14:10 ` [PATCH 06/45] perf tools: Add cpu_map__new_event function Jiri Olsa
2015-09-30 14:10 ` [PATCH 07/45] perf tools: Add stat config event Jiri Olsa
2015-09-30 14:10 ` [PATCH 08/45] perf tools: Add stat config event synthesize function Jiri Olsa
2015-09-30 14:10 ` [PATCH 09/45] perf tools: Add stat config event read function Jiri Olsa
2015-09-30 14:10 ` [PATCH 10/45] perf tools: Add stat event Jiri Olsa
2015-09-30 14:10 ` [PATCH 11/45] perf tools: Add stat event synthesize function Jiri Olsa
2015-09-30 14:10 ` [PATCH 12/45] perf tools: Add stat event read function Jiri Olsa
2015-09-30 14:10 ` [PATCH 13/45] perf tools: Add stat round event Jiri Olsa
2015-09-30 14:10 ` [PATCH 14/45] perf tools: Add stat round event synthesize function Jiri Olsa
2015-09-30 14:10 ` [PATCH 15/45] perf tools: Introduce stat feature Jiri Olsa
2015-09-30 14:10 ` [PATCH 16/45] perf tools: Move id_offset out of struct perf_evsel union Jiri Olsa
2015-09-30 14:10 ` [PATCH 17/45] perf stat: Rename perf_stat struct into perf_stat_evsel Jiri Olsa
2015-09-30 14:10 ` [PATCH 18/45] perf stat: Add AGGR_UNSET mode Jiri Olsa
2015-09-30 14:10 ` [PATCH 19/45] perf stat record: Add record command Jiri Olsa
2015-09-30 14:10 ` [PATCH 20/45] perf stat record: Initialize record features Jiri Olsa
2015-09-30 14:10 ` [PATCH 21/45] perf stat record: Synthesize stat record data Jiri Olsa
2015-09-30 14:10 ` [PATCH 22/45] perf stat record: Store events IDs in perf data file Jiri Olsa
2015-09-30 14:10 ` [PATCH 23/45] perf stat record: Add pipe support for record command Jiri Olsa
2015-09-30 14:10 ` [PATCH 24/45] perf stat record: Write stat events on record Jiri Olsa
2015-09-30 14:10 ` [PATCH 25/45] perf stat record: Write stat round " Jiri Olsa
2015-09-30 14:10 ` [PATCH 26/45] perf stat record: Do not allow record with multiple runs mode Jiri Olsa
2015-09-30 14:10 ` [PATCH 27/45] perf tools: Add cpu_map__empty_new interface Jiri Olsa
2015-09-30 14:10 ` [PATCH 28/45] perf tools: Make cpu_map__build_map global Jiri Olsa
2015-09-30 14:10 ` [PATCH 29/45] perf tools: Add data arg to cpu_map__build_map callback Jiri Olsa
2015-09-30 14:10 ` [PATCH 30/45] perf stat report: Cache aggregated map entries in extra cpumap Jiri Olsa
2015-09-30 14:10 ` Jiri Olsa [this message]
2015-09-30 14:10 ` [PATCH 32/45] perf stat report: Process cpu/threads maps Jiri Olsa
2015-09-30 14:10 ` [PATCH 33/45] perf stat report: Process stat config event Jiri Olsa
2015-09-30 14:10 ` [PATCH 34/45] perf stat report: Add support to initialize aggr_map from file Jiri Olsa
2015-09-30 14:10 ` [PATCH 35/45] perf stat report: Process stat and stat round events Jiri Olsa
2015-09-30 14:10 ` [PATCH 36/45] perf stat report: Move csv_sep initialization before report command Jiri Olsa
2015-09-30 14:10 ` [PATCH 37/45] perf stat report: Allow to override aggr_mode Jiri Olsa
2015-09-30 14:10 ` [PATCH 38/45] perf script: Check output fields only for samples Jiri Olsa
2015-09-30 14:10 ` [PATCH 39/45] perf script: Process cpu/threads maps Jiri Olsa
2015-09-30 14:10 ` [PATCH 40/45] perf script: Process stat config event Jiri Olsa
2015-09-30 14:10 ` [PATCH 41/45] perf script: Add process_stat/process_stat_interval scripting interface Jiri Olsa
2015-09-30 14:10 ` [PATCH 42/45] perf script: Add stat default handlers Jiri Olsa
2015-09-30 14:10 ` [PATCH 43/45] perf script: Display stat events by default Jiri Olsa
2015-09-30 14:10 ` [PATCH 44/45] perf script: Add python support for stat events Jiri Olsa
2015-09-30 14:10 ` [PATCH 45/45] perf script: Add stat-cpi.py script Jiri Olsa
2015-09-30 21:09 ` [PATCHv2 00/45] perf stat: Add scripting support Liang, Kan
2015-09-30 21:34   ` Jiri Olsa
2015-09-30 21:36   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443622258-17158-32-git-send-email-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome