From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933336AbbI3SdE (ORCPT ); Wed, 30 Sep 2015 14:33:04 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:35900 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932807AbbI3ScT (ORCPT ); Wed, 30 Sep 2015 14:32:19 -0400 From: Rasmus Villemoes To: Mark Brown , Greg Kroah-Hartman Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] regmap: debugfs: use memcpy instead of snprintf Date: Wed, 30 Sep 2015 20:30:26 +0200 Message-Id: <1443637827-18875-2-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1443637827-18875-1-git-send-email-linux@rasmusvillemoes.dk> References: <1443479342-31621-2-git-send-email-linux@rasmusvillemoes.dk> <1443637827-18875-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we know the length of entry and that there's room enough in the output buffer, using memcpy instead of snprintf is simpler and cheaper. Signed-off-by: Rasmus Villemoes --- drivers/base/regmap/regmap-debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index d26b9c3ab812..bed690740efa 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -372,8 +372,7 @@ static ssize_t regmap_reg_ranges_read_file(struct file *file, if (p >= *ppos) { if (buf_pos + 1 + entry_len > count) break; - snprintf(buf + buf_pos, count - buf_pos, - "%s", entry); + memcpy(buf + buf_pos, entry, entry_len); buf_pos += entry_len; buf[buf_pos] = '\n'; buf_pos++; -- 2.1.3