From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755294AbbI3Xmq (ORCPT ); Wed, 30 Sep 2015 19:42:46 -0400 Received: from mail-bl2on0121.outbound.protection.outlook.com ([65.55.169.121]:30808 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755172AbbI3Xmm (ORCPT ); Wed, 30 Sep 2015 19:42:42 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none;freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; From: Lijun Pan To: , CC: Lijun Pan Subject: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA Date: Wed, 30 Sep 2015 17:55:42 -0500 Message-ID: <1443653742-23177-1-git-send-email-Lijun.Pan@freescale.com> X-Mailer: git-send-email 2.3.3 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD020;1:npCHeUnd/E6WiHwc+fbVewqqFqEls3WutwZ52gvus6OCq/isxUppC6AtnO7GdiJoZGZcZ4PxDr9tUiBkQ1eJDXornonmAJzL5r3l70J+0HkGbyqxq+RPhHBhMP9NdbyHR4BF2W8oOxm0JxRWKeAI6WzXwErObJkrWr9RxkOv2SVWI6JsKWI5vu40Pb0KzEjCfgJJ2rUM5vwFE+IVwypNyzpX63UDkthiG7dpT+KdCbtho0FsFlSK6aZR/UzOUYB/NkgaEB4hHcvhlRCNPObhYlMCuGCHyWd9kljQopugGpVEtlIvT/PldS/1jNYkXpa+gIjqLq9oJA6nKGF5MHOiVoWKu17GA/Wlay+1DnGz9xQZkVYkFNRcM/f2igKki//9psDVCJQCCRQN74nb1kRmVQ== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(86362001)(4001540100001)(23676002)(68736005)(6806005)(85426001)(36756003)(104016004)(81156007)(77156002)(5008740100001)(5001830100001)(5001770100001)(5001860100001)(97736004)(62966003)(50226001)(77096005)(5820100001)(64706001)(19580405001)(107886002)(5001960100002)(50466002)(19580395003)(106466001)(92566002)(11100500001)(87936001)(189998001)(105606002)(229853001)(46102003)(47776003)(5007970100001)(50986999)(2004002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1454;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1454;2:ibFRt4eQOK8sgiQB8fZgRk/1E4BDHWDvRpW6gLKHPj+hWNGSwk1HjQI6N5wVFcyB6HnipyWO+JtbK4Nt5Gd/cs6hmGgzz3vO8mJY3Y/PJejkxtmpAqeAjVk0EBEGmrr92ltRtWI+0chWI6oiae9Fi2XkzD5OTk8uTyRTWH8i/2A=;3:RglJLQ4skgCrsZjTmWWU6HqiTHYqQ4amyCHVtg0gO439ciSIh8qB/iZO94tFaaUMsQqY6pB2HsERyiS3bJHZwUGxlOPkY4fu1E5WOk84NR3fraB2M5gcapw+VKsZ81EG8hx17KkmVuCd+zjJhn6HWuzwyHpKDQPlDKE9kdAfb1z7E6ysVBCQHPRn5iXf9OofkMTN7DVbi6U7ye6U9QFbAvPZ0ZWCk6CTS7TQoeLlwSU=;25:nLAf8OotkkoLSeGssN8l9eBqFZMd5nAydyp6EA+7zrHri1YqLAbplQLn7ld6fPQP4HrY7RD4OnNWMi5P6SnWxb10S1lViZC+YuuNnvOccuc5iXVaf6lP88i7mee4OqZf7vDE2WR3VHT1PPDhMQ1U1dB8s9A7GAjBruCdc4OIGgcSLHIa+M5Saoze5Ci1o0fE1Wcrx46X6qELQmXrEDEe+c7iCRSK4/ckNDQa9NYmgNYZkulrwtIG07ukVgQwLG7uPmhz5agsj3W+AyovEFazpQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1454; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1454;20:lY8lkpRwcbSnsoh/2JKKcevcOf3lGPJzLrCiuQ09HgVF16df1X8Kl6c2h7bu7RjRkexASR4PrrJlaadjJ7u2bMxiqab8/20G9XlyIpnYSz5P55jdEvfHi2P20vZjG7KOAgTZVP2C9LrAub4IDTVt9P17U3zhFVI7CWkI/jn+dd29x1AFzDd/U26vObMPdohKoUIVoFMJytBj0Kdv26zuqm0nPyDbZ0ha/g/29SSkC+vQZCQnhiE3xoWNrRDJ1lYN63uotSd64kTWwgB9rmsW7X5JtgBGS11a4deqZ682+BnMjJWBn5q/1ta8xa2egXhCPDkZir9lFLJG2B7l1chhAUkr9T8G2txPG2jHbwntezo=;4:q5nY1hkU5vhBsCCOnwPr0DxTn+XcGuLfXMFRUSv2psO7oUbtVepsMyjDvpXOny2F2i1/ihMvQnOCFgAik3mUdjbcQ6kiOToKMPuJfjKMkyLwe205PIawe8nJdZd18FyvIOuY7YbP12GWye8CzIEzKLgBCNMY8ZQwUJmIiRrchb4Pz1m1L+Y7FZBMfYvqKppM1TahrgJLXE0aZm59OScbyt9sYt7oFFjFZvagOYH1/GO0OiQeyFG/jYAr/6z/HWw7B8QubsCgPSRSz8ibkHAfFpp+M0XNTG4jByLKimjCCj2u3h5AojwG/RpFlEPY8QTBc/93UCZGR6Ts5Wyc6YZZSUbJquKJ55bA/UxR1vDQiVI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:CY1PR03MB1454;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1454; X-Forefront-PRVS: 071518EF63 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDU0OzIzOmRhMFhLNUlPVFJoTXlPYXI5YTJQbDZTMmxI?= =?utf-8?B?cG8reS93OE5vOTlBT2xsckVHOFdCSTAvUWJ0c0V1Mis3Ny9vWlhDRis5TnB5?= =?utf-8?B?RWM3bHVMRElCcHYyUVdIMGtDblNGNTFJaUxKSlptUFd5QjIreFJRdVpkMmg2?= =?utf-8?B?Q1BSR3FuSmFUQWtyZTZBYTBXWFpXbWNQVlRXUkFOa3EyMTZ1MWUxYmhadkJF?= =?utf-8?B?Tks3cnFPcHFxZHdnOC82aUl6Z0lVZ0d3NmtaZVY5YVArVkRjNUJMUG4rTWwx?= =?utf-8?B?UGRmZTZPYzA2elJDMlI2d05PSnlHUXA2ZGFyRVg5NnlEcjJQU0lIR2pXSXdj?= =?utf-8?B?WUN1TTQ5VHJ4VFhwaG55ZXc0SnVKWFV3cmlQaHV6MDFGaXlYRGMyNWZvc2R1?= =?utf-8?B?MHp0RDlodlIvLzhBdFZtMm83TFdOWHQ3SDcrencxc0JYcWFhZUVYUjkyWEpG?= =?utf-8?B?YWF4RURwYkJRVVRNNE16Rk9sNFFJT0RKVzhzSXpDWjFkb0QvMEV3dWlCWFUx?= =?utf-8?B?MXhFT1UvS0NvR3RibWY5NngwVXNGaG96dHNLdUZHelU2TCtqUWpOOVAwTDQ2?= =?utf-8?B?c3JyYlZpNFhFazBHa0tEbnBpdU5qRUpOeXFlQ1hzWVZHdkVac3BBOHV5cndj?= =?utf-8?B?WkVQT2I5NG4wQmpOTGpValRna3dEMXdEdG54Q3NYWXlSejc0QUtHaHVPM3gv?= =?utf-8?B?dCtKMWhqWWF5QTllaWpzN0lwUHFKSkNGcXdOS2hnbEJOZU9pNnFpeUJLUjBx?= =?utf-8?B?aG92clJuRUVFLzFtKy9XbU9PK2ExRTZIVHZkenRYcjdGcmJNeHZXSk9TdzBt?= =?utf-8?B?eXlrNTdlaFh5V0dlbXRsL1VpQjNyTy81TCtVUTQyYXFNdEJLekxlMlkvek1H?= =?utf-8?B?eGJMZjI0UUlzbnc1bGFkcEJ4ZlNPZFBVS3BPNFg1VmwrUkdRVERST0pPSnFn?= =?utf-8?B?RlZvWTM1QldzYnVPbXkwT3dJNUxQdUhiWGxKNlhuRGNpSy8xRDM0RGVJa2pP?= =?utf-8?B?RFEvTE1VQXpkOUQ3VlNXVjljcEQ1aUszcy9OTVFYMndOTFhvWThoOWExOU02?= =?utf-8?B?blVYRVQwTFJkTUhmRVhLbllLM1VMdTM0NExCNi9Ka3d0ZkxDdXNlRUkxNlBq?= =?utf-8?B?QXhhWHZJUUVJS3N2clNUWUh4TzJ0OUNoQ3loZEtxMUxZTHJ1UHFpam9EZVpK?= =?utf-8?B?WmZzODJZQXYvUHhBRHR5d2hwemdNbzdpWXphR1FFSDFBd3RaNTJSUUFDT014?= =?utf-8?B?M0lPYjdjOTdwTWdGSGZTV2hZQVE3SER1YklxZU9GQkRZQTVSUWtKdXBIYzND?= =?utf-8?B?OTZmSEVoRC80VUFOR0F1cXZFZHYwTm5GTkRqY25IeUFNbW13ajU3VVV5Z1F0?= =?utf-8?B?K2lWWHpXbFdaVlBramJwWWxLZmZkMTFNRXoxOEN2MHRjeWxiSklxT2RmTlJJ?= =?utf-8?B?V0V4SmxUditDYU1VcXhqQmZIWHVTbHpDQ3dWU2dURWpqM2V0cm1FOWljOUZG?= =?utf-8?B?M0MyYktpWjJxckwwWFEyalVjRzJVcVpjVUNqdzJmNVFiNG5aVmpwS3ExVzN0?= =?utf-8?B?dG40UlhqYzhkRXNvalFJYzJDdXhDUzEyRVNJcWxtQUw4WkkzUCtTUWJVNUJy?= =?utf-8?B?Mk1MSjgvVVZrOHlvWkl6cDQ2Y09IR1FVNjV6a01pYU5VWXdMN0h5eWxRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1454;5:i78EjGrJhlBbFL6SUCfD2CC/9ehrXjEsMqE92vMLAxVetguj7yFvlja38rT4Y3QqHZyfuoCQPoeTnrzpSxJXvUvQbWkpY1h+4rFJm38D1kk46nWmMCco51TeEDZTqimxDeQ1uXZl+QGDccY0R3BcJQ==;24:tcpxdQtVjbyLGmLsAQRf46O+nohxz2mvP6hcdAS6QxOTzbrs5nJWNzVvXyCOpPawkprmdHDA5QzTPmYrRpdo4qCwFob0rQn4g8qhJhAtdVE=;20:OWz7eYLx8wiAQtIgFIhGW8uLaxTxG6HL5MXwjqxBHvrMTESB5O08P7JK0Axi4MtNCHbm/zoeH7IMijByE8G2yQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2015 23:09:58.8132 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1454 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Need to include sched.h to fix the following compilation error if FSL_IFC is enabled on ARM64 machine. Also, sort the include files by alphabetical order. In file included from include/linux/mmzone.h:9:0, from include/linux/gfp.h:5, from include/linux/kmod.h:22, from include/linux/module.h:13, from drivers/memory/fsl_ifc.c:22: drivers/memory/fsl_ifc.c: In function ‘check_nand_stat’: include/linux/wait.h:165:35: error: ‘TASK_NORMAL’ undeclared (first use in this function) #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL) ^ drivers/memory/fsl_ifc.c:136:3: note: in expansion of macro ‘wake_up’ wake_up(&ctrl->nand_wait); ^ include/linux/wait.h:165:35: note: each undeclared identifier is reported only once for each function it appears in #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL) ^ drivers/memory/fsl_ifc.c:136:3: note: in expansion of macro ‘wake_up’ wake_up(&ctrl->nand_wait); ^ Analysis is as follows: I put some instrumental code and get the following .h files inclusion sequence: In file included from ./arch/arm64/include/asm/compat.h:25:0, from ./arch/arm64/include/asm/stat.h:23, from include/linux/stat.h:5, from include/linux/module.h:10, from drivers/memory/fsl_ifc.c:23: include/linux/sched.h:113:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘struct’ struct sched_attr { ^ When 42 bit VA is selected, it does not enable CONFIG_COMPAT=y In ./arch/arm64/include/asm/stat.h:23, it has "#ifdef CONFIG_COMPAT" "#include " "..." "#endif" Since ./arch/arm64/include/asm/stat.h does not include ./arch/arm64/include/asm/compat.h, it will not include include/linux/sched.h Hence we have to manually add "#include " in drivers/memory/fsl_ifc.c Signed-off-by: Lijun Pan --- v2: reordering the include .h files according to Arnd's suggestion detailing why linux/sched.h is needed. drivers/memory/fsl_ifc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c index e87459f..defd62e 100644 --- a/drivers/memory/fsl_ifc.c +++ b/drivers/memory/fsl_ifc.c @@ -19,17 +19,18 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#include -#include #include -#include -#include -#include +#include #include +#include +#include #include #include #include -#include +#include +#include +#include +#include #include struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev; -- 2.3.3