From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbbJAOhK (ORCPT ); Thu, 1 Oct 2015 10:37:10 -0400 Received: from m50-132.163.com ([123.125.50.132]:48271 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbbJAOhF (ORCPT ); Thu, 1 Oct 2015 10:37:05 -0400 From: Geliang Tang To: Sebastian Reichel Cc: Geliang Tang , linux-kernel@vger.kernel.org Subject: [PATCH v2] hsi: fix double kfree Date: Thu, 1 Oct 2015 22:35:21 +0800 Message-Id: <1443710121-10251-1-git-send-email-geliangtang@163.com> X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: DNGowEDJDG6wRA1WbKSzAw--.33918S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrurWkJF47tw1rGF1rZrW3Awb_yoWxtrcEkF 40qF18urn5tFWfGa45KrWfZryIkayqqFs3JFW7KFs3AryrXrZrKrWUZr4kA3WUGr4UC3s8 Ar4Dur4kZr1UKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xREWEE5UUUUU== X-Originating-IP: [116.77.129.9] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiJROGmVUL7PNBtgAAsf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When device_register() fails, kfree() is called in hsi_client_release(), hence there is no need to call kfree in err3 again. Signed-off-by: Geliang Tang --- Changes in v2: - Just to make myself clearer that what I did in this patch. --- drivers/hsi/hsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c index fe93712..35d631e 100644 --- a/drivers/hsi/hsi.c +++ b/drivers/hsi/hsi.c @@ -300,7 +300,6 @@ static void hsi_add_client_from_dt(struct hsi_port *port, if (device_register(&cl->device) < 0) { pr_err("hsi: failed to register client: %s\n", name); put_device(&cl->device); - goto err3; } return; -- 2.5.0