From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757287AbbJAUye (ORCPT ); Thu, 1 Oct 2015 16:54:34 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:55603 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753537AbbJAUyb (ORCPT ); Thu, 1 Oct 2015 16:54:31 -0400 Message-ID: <1443732858.2730.66.camel@decadent.org.uk> Subject: Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 From: Ben Hutchings To: Brian Gerst , Ingo Molnar Cc: the arch/x86 maintainers , LKML , Peter Zijlstra Date: Thu, 01 Oct 2015 21:54:18 +0100 In-Reply-To: References: <1443660043.2730.15.camel@decadent.org.uk> <20151001082333.GA1486@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hiLGvA9YRgP7wk7vsk+y" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-hiLGvA9YRgP7wk7vsk+y Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-10-01 at 09:02 -0400, Brian Gerst wrote: > On Thu, Oct 1, 2015 at 4:23 AM, Ingo Molnar wrote: > >=20 > > * Ben Hutchings wrote: > >=20 > > > diff --git a/arch/x86/include/uapi/asm/bitsperlong.h > > > b/arch/x86/include/uapi/asm/bitsperlong.h > > > index b0ae1c4..217909b 100644 > > > --- a/arch/x86/include/uapi/asm/bitsperlong.h > > > +++ b/arch/x86/include/uapi/asm/bitsperlong.h > > > @@ -1,7 +1,7 @@ > > > #ifndef __ASM_X86_BITSPERLONG_H > > > #define __ASM_X86_BITSPERLONG_H > > >=20 > > > -#ifdef __x86_64__ > > > +#if defined(__x86_64__) && !defined(__ILP32__) > > > # define __BITS_PER_LONG 64 > >=20 > > Can we write this as: > >=20 > > #ifdef __ILP64__ Assuming you meant __LP64__... > Do all versions of gcc/clang define that, even if x32 isn't > supported? For gcc, it's been defined since 2003 (gcc 3.3): https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3D0bdab2d89e28ca4dc84f8f0= fafed85a4822bca49 For clang, it's been defined since before its first public release: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?r1=3D38= 978&r2=3D38987&pathrev=3D161685 So gcc 3.1 and 3.2 didn't define it, but everything newer does. Ben. --=20 Ben Hutchings Knowledge is power. France is bacon. --=-hiLGvA9YRgP7wk7vsk+y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVg2deue/yOyVhhEJAQo17w//cmr5uGbRH6fVN/GprGQRqMNui+/YLd8J JVVauLF6vV+KTX4n9WYgRwByjet8otSNpvqB85T3AuelzY4udqgD/Yj2VOU4UDQR F0YRvzKTrSoH9hSeWjcu1Keyk6abKC32CgUSiHUif/YSMjTKjZFLclfIIt4tgBaj FV7wCHxR7IufHu3/t25++e3KGrpS4dOGV7LGL5WC6QqtV8OOTxMCJdDw7GyhEC9r viWamtUptk/4z+6YkFzJ+/F/REe72/EFHyU49S1zfqElwxaSmPokgxbmyBF+g0IK 8X41jwXN8kwB7VoNtc7pHL4R2BWrdSN9j3bd+cBO8MSOjpbPRRoEBAh35LeHIbwM xfad1HCtjNxTeJM8C/ARFjruDIqPF2XUDBWswqKYGwJI0h/SA3d/JgUPxRCVpm1A 8TcnQd/gqAfnPCwze06VTBRjfpa/hy1NRUHZAcx9k2s49GWR3FtvHqcpdm7pazCg NTe1VTDRu7y7R6J+KdwWT6F6o2hS3vjb+6vggtxn7AcaX601d5gZewF25SW2NyQO NQrmVAdM9bYXl4RTU+fAR8vwJdXW4FGiMZ5RMDwKzDTs4RL9YJ8aTK5F2Tvl+lku 9q2PIcn+Sj9B+F/rLK1oIEmVa8hCpbwfeM3CwL4m3D3XzSFP+C2qXelxp5zPgLy6 GuoMceg9P84= =yIJB -----END PGP SIGNATURE----- --=-hiLGvA9YRgP7wk7vsk+y--