From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751185AbbJBBwk (ORCPT ); Thu, 1 Oct 2015 21:52:40 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:56593 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbbJBBwj (ORCPT ); Thu, 1 Oct 2015 21:52:39 -0400 Message-ID: <1443750747.2730.115.camel@decadent.org.uk> Subject: Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32 From: Ben Hutchings To: Brian Gerst , Ingo Molnar Cc: the arch/x86 maintainers , LKML , Peter Zijlstra Date: Fri, 02 Oct 2015 02:52:27 +0100 In-Reply-To: <1443732858.2730.66.camel@decadent.org.uk> References: <1443660043.2730.15.camel@decadent.org.uk> <20151001082333.GA1486@gmail.com> <1443732858.2730.66.camel@decadent.org.uk> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-l6aov0hbuxiDXKgqYi39" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-l6aov0hbuxiDXKgqYi39 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-10-01 at 21:54 +0100, Ben Hutchings wrote: > On Thu, 2015-10-01 at 09:02 -0400, Brian Gerst wrote: > > On Thu, Oct 1, 2015 at 4:23 AM, Ingo Molnar wrote: > > >=20 > > > * Ben Hutchings wrote: > > >=20 > > > > diff --git a/arch/x86/include/uapi/asm/bitsperlong.h > > > > b/arch/x86/include/uapi/asm/bitsperlong.h > > > > index b0ae1c4..217909b 100644 > > > > --- a/arch/x86/include/uapi/asm/bitsperlong.h > > > > +++ b/arch/x86/include/uapi/asm/bitsperlong.h > > > > @@ -1,7 +1,7 @@ > > > > #ifndef __ASM_X86_BITSPERLONG_H > > > > #define __ASM_X86_BITSPERLONG_H > > > >=20 > > > > -#ifdef __x86_64__ > > > > +#if defined(__x86_64__) && !defined(__ILP32__) > > > > # define __BITS_PER_LONG 64 > > >=20 > > > Can we write this as: > > >=20 > > > #ifdef __ILP64__ >=20 > Assuming you meant __LP64__... >=20 > > Do all versions of gcc/clang define that, even if x32 isn't > > supported? >=20 > For gcc, it's been defined since 2003 (gcc 3.3): > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3D0bdab2d89e28ca4dc84f8= f0fafed85a4822bca49 >=20 > For clang, it's been defined since before its first public release: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?r1=3D= 38978&r2=3D38987&pathrev=3D161685 >=20 > So gcc 3.1 and 3.2 didn't define it, but everything newer does. As the kernel itself is supposed to still be compilable with gcc 3.2, I think this means that my patch has the right condition. Ben. --=20 Ben Hutchings When in doubt, use brute force. - Ken Thompson --=-l6aov0hbuxiDXKgqYi39 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVg3jW+e/yOyVhhEJAQpXVRAA00nzyx+V8ubDZfsbJml87LIwwhdJxLrY mf7RBsowUJ1ybDgXwjVvAjLi2LIiP1f2e+9PJruBQoYlWw5D0Nqgl0ESUIswuTu/ FlSM6OOo9mRL5ygsPncb4dIvi0J2dqz+P0tdJBIprqiNlUaaFB6UGz+4EYGhbqsY OHttec1pBIOCmP5rSmC9l/bIlAf2ySel83DHImQtrbCq8Tau0BfLKMso08PREhqM VUh6GEEPqblhelPrpSRSxig9DtiumlO1/U7mNls/4WMj0zoslGi+mncFHxqzHEpH ILw6po7rNmmIG+VcI7is+uL/wtQY5uoVtPhsrB6kDFBDS3/GBgPywzHc6aIeKhpj hWvZP+ZbUOARHsgLrcY90M/nteu+TP41A66kE3i8Iy7I5vHomyCqTj6xajJ+8Bqj LcFJ3kUzAPQdSX/eWPPYE7KpE2ACZfHjbF23kfnTwOeaoLTjFgL9y1VxTbvOMkLu nyFP7goItwSerOXVQEjaaCndS1gHJN6OdpC9vMOnQ3UfDaqX8hK7GJ/dpyZV4IlJ 669/9uEBAhLgvYJ5WcryMgzMlf0FY6XDTZXBJL/4qeUcERzHwLtDrUcaSHWR/neZ vv6Hmgluy0kFNVIXU7h2zgFthKfZcjeu4xKV2C2M/5z04Y8FuFUrw6uQNNdwoFFX 2XhUAn8xApc= =tD+E -----END PGP SIGNATURE----- --=-l6aov0hbuxiDXKgqYi39--