From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbbJBI0H (ORCPT ); Fri, 2 Oct 2015 04:26:07 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51920 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbbJBI0B (ORCPT ); Fri, 2 Oct 2015 04:26:01 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-00-560e3f966443 From: Krzysztof Kozlowski To: Sangbeom Kim , Krzysztof Kozlowski , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: [PATCH 1/3] mfd: sec-core: Dump PMIC revision to find out the HW Date: Fri, 02 Oct 2015 17:25:49 +0900 Message-id: <1443774351-28766-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGJMWRmVeSWpSXmKPExsVy+t/xa7rT7PnCDM7OErDYOGM9q8X8I+dY LV6/MLS4//Uoo8XlXXPYLGac38dksfbIXXaLiyu+MDlweNy5tofNo2/LKkaPz5vkApijuGxS UnMyy1KL9O0SuDKOP93FXPCOs+L/oy9sDYxTOLoYOTkkBEwkut90sUPYYhIX7q1nA7GFBJYy Smxrs+9i5AKy/zNKLG1aygSSYBMwlti8fAkbSEJE4BajRNOaV4wgCWaBdIkf59vAioQFPCVu L/jHDGKzCKhKPFm3hBXE5hVwl9i65jobxDY5iZPHJrNOYORewMiwilE0tTS5oDgpPddQrzgx t7g0L10vOT93EyMkNL7sYFx8zOoQowAHoxIPb8Rp3jAh1sSy4srcQ4wSHMxKIrxeSnxhQrwp iZVVqUX58UWlOanFhxilOViUxHnn7nofIiSQnliSmp2aWpBaBJNl4uCUamDUmHLPeWP4iReV J5qzz6/yfmGem8G86fYll7TzSd0+M3w8fRwLIy8w8W2oans0S/r0OvuD/ilTLVZLz0txYtaz rtNKVMm+dEVq62RZvoZP/5k2mrIrnfP15uxJru5JWH04IvRMhfgr1jy5VRlTxcLN61WlSmIl L1dUT17SPjHj/jGj6ZxiN5RYijMSDbWYi4oTAeL+qsAJAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are different revisions of the same chipset. For example S2MPS13 has more than 2 revisions. They differ slightly in regulator constraints. Print the revision number to easily find which PMIC is used on the board. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 2d1137a7a0ee..589e5efc2d7f 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -253,6 +253,15 @@ static const struct regmap_config s5m8767_regmap_config = { .cache_type = REGCACHE_FLAT, }; +static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) +{ + unsigned int val; + + /* For each device type, the REG_ID is always the first register */ + if (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val)) + dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val); +} + #ifdef CONFIG_OF /* * Only the common platform data elements for s5m8767 are parsed here from the @@ -425,6 +434,7 @@ static int sec_pmic_probe(struct i2c_client *i2c, goto err_mfd; device_init_wakeup(sec_pmic->dev, sec_pmic->wakeup); + sec_pmic_dump_rev(sec_pmic); return ret; -- 1.9.1