From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754012AbbJBNn7 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 2 Oct 2015 09:43:59 -0400
Received: from ou.quest-ce.net ([195.154.187.82]:41675 "EHLO ou.quest-ce.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753433AbbJBNn5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 2 Oct 2015 09:43:57 -0400
Message-ID: <1443793411.3188.25.camel@opteya.com>
From: Yann Droneaud <ydroneaud@opteya.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>,
        William Cohen <wcohen@redhat.com>, linux-kernel@vger.kernel.org
Date: Fri, 02 Oct 2015 15:43:31 +0200
In-Reply-To: <20151002132041.GB1673@krava.brq.redhat.com>
References: <cover.1443708092.git.ydroneaud@opteya.com>
	 <50528203b94e72fc2aa7d4e9130523a09169c00c.1443708092.git.ydroneaud@opteya.com>
	 <20151002132041.GB1673@krava.brq.redhat.com>
Organization: OPTEYA
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2001:450:1e:232:8e70:5aff:fe2f:2d74
X-SA-Exim-Mail-From: ydroneaud@opteya.com
Subject: Re: [PATCH v2 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing
 error once
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on ou.quest-ce.net)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le vendredi 02 octobre 2015 à 15:20 +0200, Jiri Olsa a écrit :
> On Thu, Oct 01, 2015 at 05:16:26PM +0200, Yann Droneaud wrote:
> > In case of failure, unrelated to PERF_FLAG_FD_CLOEXEC,
> > perf_flag_probe() reports the error twice. For example:
> > 
> >   $ perf record ls
> >   Error:
> >   perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected
> > error 16 (Device or resource busy)
> >   perf_event_open(..., 0) failed unexpectedly with error 16 (Device
> > or resource busy)
> 
> so this error message is no longer possible due to your earlier patch
> right?
> 

My bad, the error used to illustrate the behavior is not well choosed. 

> could you please provide current 'before&after' output into changelog
> otherwise it looks ok 
> 

OK. I'm updating the message.

Regards.

-- 
Yann Droneaud
OPTEYA