From: Jean-Christian de Rivaz <jc@eclis.ch>
To: Thomas Osterried <thomas@osterried.de>,
David Ranch <dranch@trinnet.net>,
Ralf Baechle DL5RB <ralf@linux-mips.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Peter Hurley <peter@hurleysoftware.com>
Cc: linux-hams@trinnet.net, linux-hams@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] Add poll method to mkiss let notify hangup to the user process.
Date: Fri, 2 Oct 2015 23:46:13 +0200 [thread overview]
Message-ID: <1443822373-18395-1-git-send-email-jc@eclis.ch> (raw)
In-Reply-To: <560EBE07.70801@eclis.ch>
Without this the application that use the mkiss line discipline have
no way to terminate in case the corresponding serial device is
removed, for example when a USB TNC is unplugged. The application must
wait on poll().
The kissattach application must be patched to take advantage of this
feature.
Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
---
drivers/net/hamradio/mkiss.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index fba41e9..50cd36c 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -893,6 +893,20 @@ static long mkiss_compat_ioctl(struct tty_struct *tty, struct file *file,
#endif
/*
+ * Waiting until hangup is the only allowed operation. This is used
+ * to notify the application in case the serial deivce is removed
+ * (ex. USB). The tty_ldisc_hangup() will wake up the process.
+ */
+static unsigned int mkiss_poll(struct tty_struct *tty, struct file *file,
+ poll_table *wait)
+{
+ poll_wait(file, &tty->read_wait, wait);
+ poll_wait(file, &tty->write_wait, wait);
+
+ return 0;
+}
+
+/*
* Handle the 'receiver data ready' interrupt.
* This function is called by the 'tty_io' module in the kernel when
* a block of data has been received, which can now be decapsulated
@@ -969,6 +983,7 @@ static struct tty_ldisc_ops ax_ldisc = {
#ifdef CONFIG_COMPAT
.compat_ioctl = mkiss_compat_ioctl,
#endif
+ .poll = mkiss_poll,
.receive_buf = mkiss_receive_buf,
.write_wakeup = mkiss_write_wakeup
};
--
1.7.10.4
prev parent reply other threads:[~2015-10-02 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151001073117.GA31401@linux-mips.org>
[not found] ` <1443691088-30478-1-git-send-email-jc@eclis.ch>
2015-10-01 16:56 ` Force mkiss to reset the line discipline when serial device is removed Jean-Christian de Rivaz
2015-10-01 22:57 ` Peter Hurley
2015-10-02 8:30 ` Jean-Christian de Rivaz
2015-10-02 10:35 ` Thomas Osterried
2015-10-02 13:48 ` Jean-Christian de Rivaz
2015-10-02 17:25 ` Jean-Christian de Rivaz
2015-10-02 21:46 ` Jean-Christian de Rivaz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443822373-18395-1-git-send-email-jc@eclis.ch \
--to=jc@eclis.ch \
--cc=dranch@trinnet.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-hams@trinnet.net \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=ralf@linux-mips.org \
--cc=thomas@osterried.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®