From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbbJENBb (ORCPT ); Mon, 5 Oct 2015 09:01:31 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:56966 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751246AbbJENBa (ORCPT ); Mon, 5 Oct 2015 09:01:30 -0400 X-Greylist: delayed 2105 seconds by postgrey-1.27 at vger.kernel.org; Mon, 05 Oct 2015 09:01:29 EDT Message-ID: <1444047974.27220.10.camel@coelho.fi> From: Luca Coelho To: Denys Vlasenko , Johannes Berg Cc: Emmanuel Grumbach , Intel Linux Wireless , Gregory Greenman , John Linville , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 05 Oct 2015 15:26:14 +0300 In-Reply-To: <1443106735-9661-1-git-send-email-dvlasenk@redhat.com> References: <1443106735-9661-1-git-send-email-dvlasenk@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 91.157.79.26 X-SA-Exim-Mail-From: luca@coelho.fi Subject: Re: [PATCH] iwlwifi: Deinline iwl_write8/write32/read32() X-SA-Exim-Version: 4.2.1 (built Mon, 06 Jul 2015 07:28:29 +0000) X-SA-Exim-Scanned: Yes (on farmhouse.coelho.fi) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Denys, On Thu, 2015-09-24 at 16:58 +0200, Denys Vlasenko wrote: > With this .config: http://busybox.net/~vda/kernel_config_ALLYES_Os, > after deinlining these functions have sizes and callsite counts > as follows: > > iwl_write8: 315 bytes, 3 calls > iwl_write32: 296 bytes, 90 calls > iwl_read32: 278 bytes, 51 calls > > Total size reduction is about 40 kbytes. > > Signed-off-by: Denys Vlasenko > CC: Johannes Berg > CC: Emmanuel Grumbach > CC: Intel Linux Wireless > CC: Gregory Greenman > CC: John Linville > CC: linux-wireless@vger.kernel.org > CC: linux-kernel@vger.kernel.org Emmanuel already wrote and applied a patch like this. Check here: http://mid.gmane.org/1442869141-31637-4-git-send-email-luca@coelho.fi Thanks for your patch anyway and for reporting this. :) -- Cheers, Luca.