From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247AbbJEO6Y (ORCPT ); Mon, 5 Oct 2015 10:58:24 -0400 Received: from ou.quest-ce.net ([195.154.187.82]:42408 "EHLO ou.quest-ce.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbbJEO6W (ORCPT ); Mon, 5 Oct 2015 10:58:22 -0400 Message-ID: <1444057073.3188.34.camel@opteya.com> From: Yann Droneaud To: Gabriel Laskar Cc: Thomas Gleixner , "David S. Miller" , Hans Verkuil , "Michael S. Tsirkin" , Greg Kroah-Hartman , Mauro Carvalho Chehab , stephen hemminger , Nicolas Dichtel , Masahiro Yamada , open list , "open list:ABI/API" Date: Mon, 05 Oct 2015 16:57:53 +0200 In-Reply-To: <1444056829-9118-1-git-send-email-gabriel@lse.epita.fr> References: <1444056829-9118-1-git-send-email-gabriel@lse.epita.fr> Organization: OPTEYA Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 92.90.26.18 X-SA-Exim-Mail-From: ydroneaud@opteya.com Subject: Re: [PATCH] timerfd: expose uapi header X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ou.quest-ce.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le lundi 05 octobre 2015 à 16:53 +0200, Gabriel Laskar a écrit : > this patch expose the timerfd apis to the userland. It is already in > glibc header sys/timerfd.h but not synchronised, and missing the > ioctl > number definition. > > Signed-off-by: Gabriel Laskar > --- > include/linux/timerfd.h | 20 +------------------- > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/timerfd.h | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 33 insertions(+), 19 deletions(-) > create mode 100644 include/uapi/linux/timerfd.h > > diff --git a/include/linux/timerfd.h b/include/linux/timerfd.h > index bd36ce4..bab0b1a 100644 > --- a/include/linux/timerfd.h > +++ b/include/linux/timerfd.h > @@ -8,23 +8,7 @@ > #ifndef _LINUX_TIMERFD_H > #define _LINUX_TIMERFD_H > > -/* For O_CLOEXEC and O_NONBLOCK */ > -#include > - > -/* For _IO helpers */ > -#include > - > -/* > - * CAREFUL: Check include/asm-generic/fcntl.h when defining > - * new flags, since they might collide with O_* ones. We want > - * to re-use O_* flags that couldn't possibly have a meaning > - * from eventfd, in order to leave a free define-space for > - * shared O_* flags. > - */ > -#define TFD_TIMER_ABSTIME (1 << 0) > -#define TFD_TIMER_CANCEL_ON_SET (1 << 1) > -#define TFD_CLOEXEC O_CLOEXEC > -#define TFD_NONBLOCK O_NONBLOCK > +#include > > #define TFD_SHARED_FCNTL_FLAGS (TFD_CLOEXEC | TFD_NONBLOCK) > /* Flags for timerfd_create. */ > @@ -32,6 +16,4 @@ > /* Flags for timerfd_settime. */ > #define TFD_SETTIME_FLAGS (TFD_TIMER_ABSTIME | > TFD_TIMER_CANCEL_ON_SET) > > -#define TFD_IOC_SET_TICKS _IOW('T', 0, u64) > - > #endif /* _LINUX_TIMERFD_H */ > diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild > index f7b2db4..874ac3f 100644 > --- a/include/uapi/linux/Kbuild > +++ b/include/uapi/linux/Kbuild > @@ -395,6 +395,7 @@ header-y += tcp_metrics.h > header-y += telephony.h > header-y += termios.h > header-y += thermal.h > +header-y += tiemrfd.h Typo here ... That should have been caught with make headers_install > header-y += time.h > header-y += times.h > header-y += timex.h > diff --git a/include/uapi/linux/timerfd.h > b/include/uapi/linux/timerfd.h > new file mode 100644 > index 0000000..69a2f92 > --- /dev/null > +++ b/include/uapi/linux/timerfd.h > @@ -0,0 +1,31 @@ > +/* > + * include/uapi/linux/timerfd.h > + * > + * Copyright (C) 2007 Davide Libenzi > + * > + */ > + > +#ifndef _UAPI_LINUX_TIMERFD_H > +#define _UAPI_LINUX_TIMERFD_H > + > +/* For O_CLOEXEC and O_NONBLOCK */ > +#include > + > +/* For _IO helpers */ > +#include > + > +/* > + * CAREFUL: Check include/asm-generic/fcntl.h when defining > + * new flags, since they might collide with O_* ones. We want > + * to re-use O_* flags that couldn't possibly have a meaning > + * from eventfd, in order to leave a free define-space for > + * shared O_* flags. > + */ > +#define TFD_TIMER_ABSTIME (1 << 0) > +#define TFD_TIMER_CANCEL_ON_SET (1 << 1) > +#define TFD_CLOEXEC O_CLOEXEC > +#define TFD_NONBLOCK O_NONBLOCK > + > +#define TFD_IOC_SET_TICKS _IOW('T', 0, u64) > + > +#endif /* _UAPI_LINUX_TIMERFD_H */ Regards. -- Yann Droneaud OPTEYA