From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbJEP14 (ORCPT ); Mon, 5 Oct 2015 11:27:56 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]:62724 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbJEP11 (ORCPT ); Mon, 5 Oct 2015 11:27:27 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWtqWFmrC5F/k8792rLukQ== X-RZG-CLASS-ID: mo00 From: Olaf Hering To: kys@microsoft.com, haiyangz@microsoft.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, Olaf Hering Subject: [PATCH 5/5] Drivers: hv: utils: use memdup_user in hvt_op_write Date: Mon, 5 Oct 2015 15:27:19 +0000 Message-Id: <1444058839-19008-6-git-send-email-olaf@aepfle.de> X-Mailer: git-send-email 2.5.2 In-Reply-To: <1444058839-19008-1-git-send-email-olaf@aepfle.de> References: <1444058839-19008-1-git-send-email-olaf@aepfle.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use memdup_user to handle OOM. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering --- drivers/hv/hv_utils_transport.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c index 1505ee6..24b2766 100644 --- a/drivers/hv/hv_utils_transport.c +++ b/drivers/hv/hv_utils_transport.c @@ -80,11 +80,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf, hvt = container_of(file->f_op, struct hvutil_transport, fops); - inmsg = kzalloc(count, GFP_KERNEL); - if (copy_from_user(inmsg, buf, count)) { - kfree(inmsg); - return -EFAULT; - } + inmsg = memdup_user(buf, count); + if (IS_ERR(inmsg)) + return PTR_ERR(inmsg); + if (hvt->on_msg(inmsg, count)) return -EFAULT; kfree(inmsg);