mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ritesh Raj Sarraf <rrs@debian.org>
To: linux-kernel@vger.kernel.org
Cc: jkosina@suse.cz, srinivas.pandruvada@linux.intel.com,
	Ritesh Raj Sarraf <rrs@debian.org>
Subject: [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips
Date: Mon,  5 Oct 2015 22:02:18 +0530	[thread overview]
Message-ID: <1444062738-4670-1-git-send-email-rrs@debian.org> (raw)

This patch is a follow-up to the one below, send by Guilhem Lettron.

The Lenovo Yoga 2 13 seems to be sold in multiple variants with minor
difference3s. IN my case, the USB ID for ITE chip is different than the
Yoga 2 11 and Yoga 3 14.

Without the quirk, no data is received from the accelerometer. I have
verified the patch, testing this on 4.3-rc4 (and 4.2 stable). With this
patch, proper orientation data is received.

rrs@learner:~/Community/UpstreamSources/linux-upstream_GIT (stable-42)$ 
monitor-sensor 
** Message: Accelerometer orientation changed: bottom-up
** Message: Light changed: 0.000000 (lux)
±** Message: Accelerometer orientation changed: left-up
** Message: Accelerometer orientation changed: bottom-up
** Message: Accelerometer orientation changed: left-up
** Message: Accelerometer orientation changed: normal
** Message: Light changed: 29.999999 (lux)

monitor-sensor can be found in the iio-sensor-proxy tool.

commit 47eeca8a4838714e582c2a3058458408a328ed60
Author: Guilhem Lettron <guilhem@lettron.fr>
Date:   Sat Jun 27 17:02:23 2015 +0200

    HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE
    
    Like yogas with TEXAS_INSTRUMENTS, yogas with ITE chips needs
    to be initialized with enumeration quirks.
    
    Signed-off-by: Jiri Kosina <jkosina@suse.com>


Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org>
---
 drivers/hid/hid-ids.h        | 1 +
 drivers/hid/hid-sensor-hub.c | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f769208..127c777 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -510,6 +510,7 @@
 
 #define USB_VENDOR_ID_ITE               0x048d
 #define USB_DEVICE_ID_ITE_LENOVO_YOGA   0x8386
+#define USB_DEVICE_ID_ITE_LENOVO_YOGA2  0x8350
 
 #define USB_VENDOR_ID_JABRA		0x0b0e
 #define USB_DEVICE_ID_JABRA_SPEAK_410	0x0412
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index a76eb2a..05afa25 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -777,6 +777,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE,
 			USB_DEVICE_ID_ITE_LENOVO_YOGA),
 			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE,
+			USB_DEVICE_ID_ITE_LENOVO_YOGA2),
+			.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
 		     HID_ANY_ID) },
 	{ }
-- 
2.6.0


             reply	other threads:[~2015-10-05 16:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 16:32 Ritesh Raj Sarraf [this message]
2015-10-05 16:42 ` Srinivas Pandruvada
2015-10-05 18:40 ` Jiri Kosina
  -- strict thread matches above, loose matches on Subject: below --
2015-10-05  6:37 Ritesh Raj Sarraf
2015-10-05  9:51 ` Greg KH
2015-10-05 11:28 ` Jiri Kosina
2015-10-05 11:42   ` Ritesh Raj Sarraf
2015-10-05 16:12     ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444062738-4670-1-git-send-email-rrs@debian.org \
    --to=rrs@debian.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®