From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbbJEQmk (ORCPT ); Mon, 5 Oct 2015 12:42:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:24656 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbJEQmj (ORCPT ); Mon, 5 Oct 2015 12:42:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,639,1437462000"; d="scan'208";a="658240360" Message-ID: <1444063327.17895.41.camel@spandruv-desk3.jf.intel.com> Subject: Re: [PATCH] Add quirk for Lenovo Yoga 2 with ITE Chips From: Srinivas Pandruvada To: Ritesh Raj Sarraf Cc: linux-kernel@vger.kernel.org, jkosina@suse.cz Date: Mon, 05 Oct 2015 09:42:07 -0700 In-Reply-To: <1444062738-4670-1-git-send-email-rrs@debian.org> References: <1444062738-4670-1-git-send-email-rrs@debian.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-10-05 at 22:02 +0530, Ritesh Raj Sarraf wrote: > This patch is a follow-up to the one below, send by Guilhem Lettron. > > The Lenovo Yoga 2 13 seems to be sold in multiple variants with minor > difference3s. IN my case, the USB ID for ITE chip is different than the > Yoga 2 11 and Yoga 3 14. > > Without the quirk, no data is received from the accelerometer. I have > verified the patch, testing this on 4.3-rc4 (and 4.2 stable). With this > patch, proper orientation data is received. > > rrs@learner:~/Community/UpstreamSources/linux-upstream_GIT (stable-42)$ > monitor-sensor > ** Message: Accelerometer orientation changed: bottom-up > ** Message: Light changed: 0.000000 (lux) > ±** Message: Accelerometer orientation changed: left-up > ** Message: Accelerometer orientation changed: bottom-up > ** Message: Accelerometer orientation changed: left-up > ** Message: Accelerometer orientation changed: normal > ** Message: Light changed: 29.999999 (lux) > > monitor-sensor can be found in the iio-sensor-proxy tool. > > commit 47eeca8a4838714e582c2a3058458408a328ed60 > Author: Guilhem Lettron > Date: Sat Jun 27 17:02:23 2015 +0200 > > HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE > > Like yogas with TEXAS_INSTRUMENTS, yogas with ITE chips needs > to be initialized with enumeration quirks. > > Signed-off-by: Jiri Kosina > > > Signed-off-by: Ritesh Raj Sarraf Acked-by: Srinivas Pandruvada > --- > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-sensor-hub.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index f769208..127c777 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -510,6 +510,7 @@ > > #define USB_VENDOR_ID_ITE 0x048d > #define USB_DEVICE_ID_ITE_LENOVO_YOGA 0x8386 > +#define USB_DEVICE_ID_ITE_LENOVO_YOGA2 0x8350 > > #define USB_VENDOR_ID_JABRA 0x0b0e > #define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412 > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index a76eb2a..05afa25 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -777,6 +777,9 @@ static const struct hid_device_id sensor_hub_devices[] = { > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE, > USB_DEVICE_ID_ITE_LENOVO_YOGA), > .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE, > + USB_DEVICE_ID_ITE_LENOVO_YOGA2), > + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID, > HID_ANY_ID) }, > { }