From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752282AbbJESGc (ORCPT ); Mon, 5 Oct 2015 14:06:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44515 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbbJESG0 (ORCPT ); Mon, 5 Oct 2015 14:06:26 -0400 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , "Liang, Kan" , Don Zickus Subject: [PATCH 3/9] perf annotate: Fix sizeof_sym_hist overflow issue Date: Mon, 5 Oct 2015 20:06:03 +0200 Message-Id: <1444068369-20978-4-git-send-email-jolsa@kernel.org> In-Reply-To: <1444068369-20978-1-git-send-email-jolsa@kernel.org> References: <1444068369-20978-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The annotated_source::sizeof_sym_hist could easily overflow int size, resulting in crash in __symbol__inc_addr_samples. Changing its type int size_t as was probably intended from beginning based on initialization code in symbol__alloc_hist. Link: http://lkml.kernel.org/n/tip-tf6ciz2mziuijvm25034qzcv@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/annotate.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h index e9996092a093..cea323d9ee7e 100644 --- a/tools/perf/util/annotate.h +++ b/tools/perf/util/annotate.h @@ -122,7 +122,7 @@ struct annotated_source { struct list_head source; struct source_line *lines; int nr_histograms; - int sizeof_sym_hist; + size_t sizeof_sym_hist; struct cyc_hist *cycles_hist; struct sym_hist histograms[0]; }; -- 2.4.3