From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbJFMOB (ORCPT ); Tue, 6 Oct 2015 08:14:01 -0400 Received: from muru.com ([72.249.23.125]:56268 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbbJFMN7 (ORCPT ); Tue, 6 Oct 2015 08:13:59 -0400 From: Tony Lindgren To: linux-kernel@vger.kernel.org Cc: Roger Quadros , linux-omap@vger.kernel.org Subject: [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC Date: Tue, 6 Oct 2015 05:13:56 -0700 Message-Id: <1444133636-31430-1-git-send-email-tony@atomide.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") added a debug option for GPMC, but somehow managed to keep it unselectable. This probably happened because I had some uncommitted changes and the GPMC option is selected in the platform specific Kconfig. Let's also update the description a bit, it does not mention that enabling the debug option also disables the reset of GPMC controller during the init as pointed out by Uwe Kleine-König . Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") Reported-by: Uwe Kleine-König Signed-off-by: Tony Lindgren --- drivers/memory/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -58,12 +58,13 @@ config OMAP_GPMC memory drives like NOR, NAND, OneNAND, SRAM. config OMAP_GPMC_DEBUG - bool + bool "Enable GPMC debug output and skip reset of GPMC during init" depends on OMAP_GPMC help Enables verbose debugging mostly to decode the bootloader provided - timings. Enable this during development to configure devices - connected to the GPMC bus. + timings. To preserve the bootloader provided timings, the reset + of GPMC is skipped during init. Enable this during development to + configure devices connected to the GPMC bus. config MVEBU_DEVBUS bool "Marvell EBU Device Bus Controller" -- 2.1.4