From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Liang, Kan" <kan.liang@intel.com>
Subject: [PATCH 21/56] perf tools: Add attr_update event name type
Date: Tue, 6 Oct 2015 21:55:00 +0200 [thread overview]
Message-ID: <1444161335-26734-22-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1444161335-26734-1-git-send-email-jolsa@kernel.org>
Adding name type attr update event, that stores/transfer
events name. Event's name is stored within perf.data's
EVENT_DESC feature, but we don't have if we get report
data from pipe.
Link: http://lkml.kernel.org/n/tip-j8b9c0ev11zisop3qup1hdy8@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/tests/attr_update.c | 24 ++++++++++++++++++++++++
tools/perf/util/event.h | 1 +
| 21 +++++++++++++++++++++
| 3 +++
4 files changed, 49 insertions(+)
diff --git a/tools/perf/tests/attr_update.c b/tools/perf/tests/attr_update.c
index bb190d3aaefd..23ba1db9b2d4 100644
--- a/tools/perf/tests/attr_update.c
+++ b/tools/perf/tests/attr_update.c
@@ -29,10 +29,29 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,
return 0;
}
+struct event_name {
+ struct perf_tool tool;
+ const char *name;
+};
+
+static int process_event_name(struct perf_tool *tool,
+ union perf_event *event,
+ struct perf_sample *sample __maybe_unused,
+ struct machine *machine __maybe_unused)
+{
+ struct event_name *tmp = container_of(tool, struct event_name, tool);
+ struct attr_update_event *ev = (struct attr_update_event*) event;
+
+ TEST_ASSERT_VAL("wrong id", ev->id == 123);
+ TEST_ASSERT_VAL("wrong name", !strcmp(ev->str, tmp->name));
+ return 0;
+}
+
int test__attr_update(void)
{
struct perf_evlist *evlist;
struct perf_evsel *evsel;
+ struct event_name tmp;
evlist = perf_evlist__new_default();
TEST_ASSERT_VAL("failed to get evlist", evlist);
@@ -54,5 +73,10 @@ int test__attr_update(void)
TEST_ASSERT_VAL("failed to synthesize attr update scale",
!perf_event__synthesize_attr_update_scale(NULL, evsel, process_event_scale));
+ tmp.name = perf_evsel__name(evsel);
+
+ TEST_ASSERT_VAL("failed to synthesize attr update name",
+ !perf_event__synthesize_attr_update_name(&tmp.tool, evsel, process_event_name));
+
return 0;
}
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index d9248975585b..88101c8fe0b1 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -286,6 +286,7 @@ struct attr_event {
enum {
PERF_ATTR_UPDATE__UNIT = 0,
PERF_ATTR_UPDATE__SCALE = 1,
+ PERF_ATTR_UPDATE__NAME = 2,
};
struct attr_update_event {
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index a47ac44f6a59..2009f1fd1188 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2741,6 +2741,24 @@ perf_event__synthesize_attr_update_scale(struct perf_tool *tool,
return err;
}
+int
+perf_event__synthesize_attr_update_name(struct perf_tool *tool,
+ struct perf_evsel *evsel,
+ perf_event__handler_t process)
+{
+ struct attr_update_event *ev;
+ size_t len = strlen(evsel->name);
+ int err;
+
+ ev = attr_update_event__alloc(len + 1, PERF_ATTR_UPDATE__NAME, evsel->id[0]);
+ if (ev == NULL)
+ return -ENOMEM;
+
+ strncpy(ev->str, evsel->name, len);
+ err = process(tool, (union perf_event*) ev, NULL, NULL);
+ free(ev);
+ return err;
+}
int perf_event__synthesize_attrs(struct perf_tool *tool,
struct perf_session *session,
@@ -2822,6 +2840,9 @@ int perf_event__process_attr_update(struct perf_tool *tool __maybe_unused,
case PERF_ATTR_UPDATE__UNIT:
evsel->unit = strdup(ev->str);
break;
+ case PERF_ATTR_UPDATE__NAME:
+ evsel->name = strdup(ev->str);
+ break;
case PERF_ATTR_UPDATE__SCALE:
evsel->scale = ev->scale;
default:
--git a/tools/perf/util/header.h b/tools/perf/util/header.h
index 628ee46e14fd..cb538ade38d3 100644
--- a/tools/perf/util/header.h
+++ b/tools/perf/util/header.h
@@ -111,6 +111,9 @@ int perf_event__synthesize_attr_update_unit(struct perf_tool *tool,
int perf_event__synthesize_attr_update_scale(struct perf_tool *tool,
struct perf_evsel *evsel,
perf_event__handler_t process);
+int perf_event__synthesize_attr_update_name(struct perf_tool *tool,
+ struct perf_evsel *evsel,
+ perf_event__handler_t process);
int perf_event__process_attr(struct perf_tool *tool, union perf_event *event,
struct perf_evlist **pevlist);
int perf_event__process_attr_update(struct perf_tool *tool __maybe_unused,
--
2.4.3
next prev parent reply other threads:[~2015-10-06 20:08 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 19:54 [PATCHv3 00/56] perf stat: Add scripting support Jiri Olsa
2015-10-06 19:54 ` [PATCH 01/56] perf tools: Add thread_map event Jiri Olsa
2015-10-06 19:54 ` [PATCH 02/56] perf tools: Add thread_map event sythesize function Jiri Olsa
2015-10-06 19:54 ` [PATCH 03/56] perf tools: Add thread_map__new_event function Jiri Olsa
2015-10-06 19:54 ` [PATCH 04/56] perf tools: Add perf_event__fprintf_thread_map function Jiri Olsa
2015-10-06 19:54 ` [PATCH 05/56] perf tools: Add cpu_map event Jiri Olsa
2015-10-06 19:54 ` [PATCH 06/56] perf tools: Add cpu_map event synthesize function Jiri Olsa
2015-10-06 19:54 ` [PATCH 07/56] perf tools: Add cpu_map__new_event function Jiri Olsa
2015-10-06 19:54 ` [PATCH 08/56] perf tools: Add perf_event__fprintf_cpu_map function Jiri Olsa
2015-10-06 19:54 ` [PATCH 09/56] perf tools: Add stat config event Jiri Olsa
2015-10-06 19:54 ` [PATCH 10/56] perf tools: Add stat config event synthesize function Jiri Olsa
2015-10-06 19:54 ` [PATCH 11/56] perf tools: Add stat config event read function Jiri Olsa
2015-10-06 19:54 ` [PATCH 12/56] perf tools: Add stat event Jiri Olsa
2015-10-06 19:54 ` [PATCH 13/56] perf tools: Add stat event synthesize function Jiri Olsa
2015-10-06 19:54 ` [PATCH 14/56] perf tools: Add stat event read function Jiri Olsa
2015-10-06 19:54 ` [PATCH 15/56] perf tools: Add stat round event Jiri Olsa
2015-10-06 19:54 ` [PATCH 16/56] perf tools: Add stat round event synthesize function Jiri Olsa
2015-10-06 19:54 ` [PATCH 17/56] perf tools: Add stat events fprintf functions Jiri Olsa
2015-10-06 19:54 ` [PATCH 18/56] perf tools: Add attr_update event Jiri Olsa
2015-10-06 19:54 ` [PATCH 19/56] perf tools: Add attr_update event unit type Jiri Olsa
2015-10-06 19:54 ` [PATCH 20/56] perf tools: Add attr_update event scale type Jiri Olsa
2015-10-06 19:55 ` Jiri Olsa [this message]
2015-10-06 19:55 ` [PATCH 22/56] perf tools: Add perf_event__fprintf_attr_update function Jiri Olsa
2015-10-06 19:55 ` [PATCH 23/56] perf report: Display newly added events in raw dump Jiri Olsa
2015-10-06 19:55 ` [PATCH 24/56] perf tools: Introduce stat feature Jiri Olsa
2015-10-06 19:55 ` [PATCH 25/56] perf tools: Move id_offset out of struct perf_evsel union Jiri Olsa
2015-10-06 19:55 ` [PATCH 26/56] perf stat: Rename perf_stat struct into perf_stat_evsel Jiri Olsa
2015-10-06 19:55 ` [PATCH 27/56] perf stat: Add AGGR_UNSET mode Jiri Olsa
2015-10-06 19:55 ` [PATCH 28/56] perf stat record: Add record command Jiri Olsa
2015-10-06 19:55 ` [PATCH 29/56] perf stat record: Initialize record features Jiri Olsa
2015-10-06 19:55 ` [PATCH 30/56] perf stat record: Synthesize stat record data Jiri Olsa
2015-10-06 19:55 ` [PATCH 31/56] perf stat record: Store events IDs in perf data file Jiri Olsa
2015-10-06 19:55 ` [PATCH 32/56] perf stat record: Add pipe support for record command Jiri Olsa
2015-10-06 19:55 ` [PATCH 33/56] perf stat record: Write stat events on record Jiri Olsa
2015-10-06 19:55 ` [PATCH 34/56] perf stat record: Write stat round " Jiri Olsa
2015-10-06 19:55 ` [PATCH 35/56] perf stat record: Do not allow record with multiple runs mode Jiri Olsa
2015-10-06 19:55 ` [PATCH 36/56] perf stat record: Synthesize attr update events Jiri Olsa
2015-10-06 19:55 ` [PATCH 37/56] perf tools: Add cpu_map__empty_new interface Jiri Olsa
2015-10-06 19:55 ` [PATCH 38/56] perf tools: Make cpu_map__build_map global Jiri Olsa
2015-10-06 19:55 ` [PATCH 39/56] perf tools: Add data arg to cpu_map__build_map callback Jiri Olsa
2015-10-06 19:55 ` [PATCH 40/56] perf stat report: Cache aggregated map entries in extra cpumap Jiri Olsa
2015-10-06 19:55 ` [PATCH 41/56] perf stat report: Add report command Jiri Olsa
2015-10-06 19:55 ` [PATCH 42/56] perf stat report: Process cpu/threads maps Jiri Olsa
2015-10-06 19:55 ` [PATCH 43/56] perf stat report: Process stat config event Jiri Olsa
2015-10-06 19:55 ` [PATCH 44/56] perf stat report: Add support to initialize aggr_map from file Jiri Olsa
2015-10-06 19:55 ` [PATCH 45/56] perf stat report: Process stat and stat round events Jiri Olsa
2015-10-06 19:55 ` [PATCH 46/56] perf stat report: Process attr update events Jiri Olsa
2015-10-06 19:55 ` [PATCH 47/56] perf stat report: Move csv_sep initialization before report command Jiri Olsa
2015-10-06 19:55 ` [PATCH 48/56] perf stat report: Allow to override aggr_mode Jiri Olsa
2015-10-06 19:55 ` [PATCH 49/56] perf script: Check output fields only for samples Jiri Olsa
2015-10-06 19:55 ` [PATCH 50/56] perf script: Process cpu/threads maps Jiri Olsa
2015-10-06 19:55 ` [PATCH 51/56] perf script: Process stat config event Jiri Olsa
2015-10-06 19:55 ` [PATCH 52/56] perf script: Add process_stat/process_stat_interval scripting interface Jiri Olsa
2015-10-06 19:55 ` [PATCH 53/56] perf script: Add stat default handlers Jiri Olsa
2015-10-06 19:55 ` [PATCH 54/56] perf script: Display stat events by default Jiri Olsa
2015-10-06 19:55 ` [PATCH 55/56] perf script: Add python support for stat events Jiri Olsa
2015-10-06 19:55 ` [PATCH 56/56] perf script: Add stat-cpi.py script Jiri Olsa
2015-10-08 18:37 ` [PATCHv3 00/56] perf stat: Add scripting support Liang, Kan
2015-10-08 20:11 ` Jiri Olsa
2015-10-09 18:31 ` Liang, Kan
2015-10-14 10:54 ` Jiri Olsa
2015-10-14 19:41 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444161335-26734-22-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome