From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbbJFWeK (ORCPT ); Tue, 6 Oct 2015 18:34:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:63189 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbbJFWeI (ORCPT ); Tue, 6 Oct 2015 18:34:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,646,1437462000"; d="scan'208";a="805123857" Subject: Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label From: Vasu Dev To: Jiri Slaby Cc: akpm@linux-foundation.org, JBottomley@Odin.com, kxie@chelsio.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Love , fcoe-devel@open-fcoe.org In-Reply-To: <1444134465-3693-1-git-send-email-jslaby@suse.cz> References: <1444134465-3693-1-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset="UTF-8" Date: Tue, 06 Oct 2015 15:34:07 -0700 Message-ID: <1444170847.5825.8.camel@lin-nd1-054.jf.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-06 at 14:27 +0200, Jiri Slaby wrote: > There is a label pointing to the start of a while loop and a goto > nested only in the loop. The goto jumps to the label in some cases. > Replace the goto and the label by simple continue. > > Signed-off-by: Jiri Slaby > Cc: Robert Love > Cc: fcoe-devel@open-fcoe.org > --- > Sent on: > May 5 > > drivers/scsi/fcoe/fcoe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c > index d3eb80c46bbe..d187ba9b361d 100644 > --- a/drivers/scsi/fcoe/fcoe.c > +++ b/drivers/scsi/fcoe/fcoe.c > @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg) > > set_user_nice(current, MIN_NICE); > > -retry: > while (!kthread_should_stop()) { > > spin_lock_bh(&p->fcoe_rx_list.lock); > @@ -1883,7 +1882,7 @@ retry: > set_current_state(TASK_INTERRUPTIBLE); > spin_unlock_bh(&p->fcoe_rx_list.lock); > schedule(); > - goto retry; > + continue; > } > > spin_unlock_bh(&p->fcoe_rx_list.lock); Acked-by: Vasu Dev