From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbbJGApF (ORCPT ); Tue, 6 Oct 2015 20:45:05 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:38790 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbJGApC (ORCPT ); Tue, 6 Oct 2015 20:45:02 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-66-56146b0b9c2b From: Krzysztof Kozlowski To: Sangbeom Kim , Krzysztof Kozlowski , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , Chanwoo Choi , Inki Dae Subject: [PATCH v2 1/3] mfd: sec-core: Dump PMIC revision to find out the HW Date: Wed, 07 Oct 2015 09:44:39 +0900 Message-id: <1444178681-16188-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgluLIzCtJLcpLzFFi42I5/e/4FV3ubJEwg01zpSw2zljPanH9y3NW i/lHzrFaTLo/gcXi9QtDi/tfjzJaXN41h81ixvl9TBZrj9xlt7i44guTA5fHnWt72Dz6tqxi 9Pi8SS6AOYrLJiU1J7MstUjfLoErY9n0W6wFE7gqFl1MamBcxdHFyMkhIWAise7kfDYIW0zi wr31QDYXh5DAUkaJNRs2M0M4/xklnt+5xgxSxSZgLLF5+RKwKhGBW4wSTWteMYI4zAIbGCVe 3+gEynBwCAv4SPw/IgfSwCKgKnG39ydYM6+Au8TtdafYIdbJSZw8Npl1AiP3AkaGVYyiqaXJ BcVJ6bmGesWJucWleel6yfm5mxgh4fJlB+PiY1aHGAU4GJV4eH8Yi4QJsSaWFVfmHmKU4GBW EuFVOCIcJsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQbG GvuLUlKSn8s8PXdFZxdLF6v8Z3fivcfzgeex5I0jAddNTPqfz5mav8Coef/v21bJu1bd8tz/ vYr1wmWRd68+vlD7fDF3b/YtEeaUWSabbxafPxrVv2vOrj1tIg/esd94uv5373W9Y3vWb1w7 Z9UR/aB5Aq8i+P8InDqeP7P+ILPUqw0/hDadK1RiKc5INNRiLipOBACYbvL9EwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are different revisions of the same chipset. For example S2MPS13 has more than 2 revisions. They differ slightly in regulator constraints. Print the revision number to easily find which PMIC is used on the board. Signed-off-by: Krzysztof Kozlowski --- Changs since v1: None. --- drivers/mfd/sec-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 2d1137a7a0ee..589e5efc2d7f 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -253,6 +253,15 @@ static const struct regmap_config s5m8767_regmap_config = { .cache_type = REGCACHE_FLAT, }; +static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) +{ + unsigned int val; + + /* For each device type, the REG_ID is always the first register */ + if (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val)) + dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val); +} + #ifdef CONFIG_OF /* * Only the common platform data elements for s5m8767 are parsed here from the @@ -425,6 +434,7 @@ static int sec_pmic_probe(struct i2c_client *i2c, goto err_mfd; device_init_wakeup(sec_pmic->dev, sec_pmic->wakeup); + sec_pmic_dump_rev(sec_pmic); return ret; -- 1.9.1