From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbbJGAqm (ORCPT ); Tue, 6 Oct 2015 20:46:42 -0400 Received: from ozlabs.org ([103.22.144.67]:47056 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbbJGAqk (ORCPT ); Tue, 6 Oct 2015 20:46:40 -0400 Message-ID: <1444178798.6794.1.camel@ellerman.id.au> Subject: Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks From: Michael Ellerman To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linuxppc-dev@ozlabs.org, naveen.n.rao@linux.vnet.ibm.com, Sukadev Bhattiprolu , linux-kernel@vger.kernel.org, eranian@google.com Date: Wed, 07 Oct 2015 11:46:38 +1100 In-Reply-To: <20150930194535.GK1944@kernel.org> References: <20150930182836.GA27858@us.ibm.com> <20150930190909.GA27570@krava.redhat.com> <20150930194535.GK1944@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-30 at 16:45 -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu: > > On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote: > > > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001 > > > From: Sukadev Bhattiprolu > > > Date: Thu, 24 Sep 2015 17:53:49 -0400 > > > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks > > > > > > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false. > > > So the weak definition for 'sample_regs_masks' doesn't get picked up. > > > > > > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition > > > error for 'perf_reg_value()' function (due to the static inline version > > > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that > > > function. > > > > > > Signed-off-by: Sukadev Bhattiprolu > > > > Acked-by: Jiri Olsa > > Thanks, applied. Is this going to Linus' tree any time soon? I have folks pinging me to say that perf is broken on powerpc. cheers