From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751271AbbJGGxa (ORCPT ); Wed, 7 Oct 2015 02:53:30 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:19223 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbbJGGx3 (ORCPT ); Wed, 7 Oct 2015 02:53:29 -0400 X-Greylist: delayed 1492 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Oct 2015 02:53:28 EDT From: "Denis V. Lunev" Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, Andrey Smetanin , "Denis V. Lunev" , "K. Y. Srinivasan" , Haiyang Zhang , Vitaly Kuznetsov Subject: [PATCH 1/1] drivers/hv: cleanup synic msrs if vmbus connect failed Date: Wed, 7 Oct 2015 09:28:07 +0300 Message-Id: <1444199287-5676-1-git-send-email-den@openvz.org> X-Mailer: git-send-email 2.1.4 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrey Smetanin Before vmbus_connect() synic is setup per vcpu - this means hypervisor receives writes at synic msr's and probably allocate hypervisor resources per synic setup. If vmbus_connect() failed for some reason it's neccessary to cleanup synic setup by call hv_synic_cleanup() at each vcpu to get a chance to free allocated resources by hypervisor per synic. This patch does appropriate cleanup in case of vmbus_connect() failure. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: "K. Y. Srinivasan" CC: Haiyang Zhang CC: Vitaly Kuznetsov --- drivers/hv/vmbus_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index f19b6f7..3297731 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -867,7 +867,7 @@ static int vmbus_bus_init(int irq) on_each_cpu(hv_synic_init, NULL, 1); ret = vmbus_connect(); if (ret) - goto err_alloc; + goto err_connect; if (vmbus_proto_version > VERSION_WIN7) cpu_hotplug_disable(); @@ -885,6 +885,8 @@ static int vmbus_bus_init(int irq) return 0; +err_connect: + on_each_cpu(hv_synic_cleanup, NULL, 1); err_alloc: hv_synic_free(); hv_remove_vmbus_irq(); -- 2.1.4