From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753099AbbJGJMw (ORCPT ); Wed, 7 Oct 2015 05:12:52 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:55898 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbbJGJLS (ORCPT ); Wed, 7 Oct 2015 05:11:18 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-3e-5614e1b42571 From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, pavel@ucw.cz, sakari.ailus@linux.intel.com, andrew@lunn.ch, Jacek Anaszewski Subject: [PATCH v3 08/10] leds: aat1290: Remove work queue Date: Wed, 07 Oct 2015 11:10:46 +0200 Message-id: <1444209048-29415-9-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1444209048-29415-1-git-send-email-j.anaszewski@samsung.com> References: <1444209048-29415-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e+xoO6WhyJhBuseW1ucv3uI2aL36nNG i8u75rBZbH2zjtHi7qmjbBaftnxjcmDzmHcy0GPnjs9MHn1bVjF6rFj9nd3j8ya5ANYoLpuU 1JzMstQifbsEroy131gL+uUqTk/tZ25gvCTZxcjJISFgInH21AFGCFtM4sK99WxdjFwcQgKz GCXe9h2Gcn4ySkxuOcMGUsUmYCjx88Vrpi5GDg4RATmJnWcqQWqYBboZJZZd7gKbJCxgJfG5 dwo7iM0ioCqx4ts6ZpB6XgEPidVL3EFMCQEFiTmTbEAqOAU8JRp7TzCB2EJAFYd/fWGbwMi7 gJFhFaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwKD2T2sF4cJf7IUYBDkYlHt4fxiJh QqyJZcWVuYcYJTiYlUR4F94DCvGmJFZWpRblxxeV5qQWH2KU5mBREue9cYghTEggPbEkNTs1 tSC1CCbLxMEp1cAos8rik6ggw0e7oD03LGojljxv5fpw6t23htrmE1NOME78cfPbUu3pjTfj TwgV7n748cZJ1fdeHfPby98Jzwpu5362cfYf1x27X6usOxWlmNiTpqXqs+xtk9LR4jDuc9K3 fzUzW6jdYts0xfzcnEl8Co/NNzbGPzW8IrT3+ar9nUrel12OFR57rMRSnJFoqMVcVJwIAKH4 CIYhAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now the core implements the work queue, remove it from the drivers, and switch to using brightness_set_blocking op. Signed-off-by: Jacek Anaszewski Acked-by: Sakari Ailus --- drivers/leds/leds-aat1290.c | 50 +++++++++++-------------------------------- 1 file changed, 13 insertions(+), 37 deletions(-) diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c index c56f9a9..f225930 100644 --- a/drivers/leds/leds-aat1290.c +++ b/drivers/leds/leds-aat1290.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #define AAT1290_MOVIE_MODE_CURRENT_ADDR 17 @@ -82,8 +81,6 @@ struct aat1290_led { /* brightness cache */ unsigned int torch_brightness; - /* assures led-triggers compatibility */ - struct work_struct work_brightness_set; }; static struct aat1290_led *fled_cdev_to_led( @@ -92,6 +89,12 @@ static struct aat1290_led *fled_cdev_to_led( return container_of(fled_cdev, struct aat1290_led, fled_cdev); } +static struct led_classdev_flash *led_cdev_to_fled_cdev( + struct led_classdev *led_cdev) +{ + return container_of(led_cdev, struct led_classdev_flash, led_cdev); +} + static void aat1290_as2cwire_write(struct aat1290_led *led, int addr, int value) { int i; @@ -134,9 +137,14 @@ static void aat1290_set_flash_safety_timer(struct aat1290_led *led, flash_tm_reg); } -static void aat1290_brightness_set(struct aat1290_led *led, +/* LED subsystem callbacks */ + +static int aat1290_led_brightness_set(struct led_classdev *led_cdev, enum led_brightness brightness) { + struct led_classdev_flash *fled_cdev = led_cdev_to_fled_cdev(led_cdev); + struct aat1290_led *led = fled_cdev_to_led(fled_cdev); + mutex_lock(&led->lock); if (brightness == 0) { @@ -158,35 +166,6 @@ static void aat1290_brightness_set(struct aat1290_led *led, } mutex_unlock(&led->lock); -} - -/* LED subsystem callbacks */ - -static void aat1290_brightness_set_work(struct work_struct *work) -{ - struct aat1290_led *led = - container_of(work, struct aat1290_led, work_brightness_set); - - aat1290_brightness_set(led, led->torch_brightness); -} - -static void aat1290_led_brightness_set(struct led_classdev *led_cdev, - enum led_brightness brightness) -{ - struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev); - struct aat1290_led *led = fled_cdev_to_led(fled_cdev); - - led->torch_brightness = brightness; - schedule_work(&led->work_brightness_set); -} - -static int aat1290_led_brightness_set_sync(struct led_classdev *led_cdev, - enum led_brightness brightness) -{ - struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev); - struct aat1290_led *led = fled_cdev_to_led(fled_cdev); - - aat1290_brightness_set(led, brightness); return 0; } @@ -509,11 +488,9 @@ static int aat1290_led_probe(struct platform_device *pdev) mutex_init(&led->lock); /* Initialize LED Flash class device */ - led_cdev->brightness_set = aat1290_led_brightness_set; - led_cdev->brightness_set_blocking = aat1290_led_brightness_set_sync; + led_cdev->brightness_set_blocking = aat1290_led_brightness_set; led_cdev->max_brightness = led_cfg.max_brightness; led_cdev->flags |= LED_DEV_CAP_FLASH; - INIT_WORK(&led->work_brightness_set, aat1290_brightness_set_work); aat1290_init_flash_timeout(led, &led_cfg); @@ -548,7 +525,6 @@ static int aat1290_led_remove(struct platform_device *pdev) v4l2_flash_release(led->v4l2_flash); led_classdev_flash_unregister(&led->fled_cdev); - cancel_work_sync(&led->work_brightness_set); mutex_destroy(&led->lock); -- 1.7.9.5