From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751796AbbJGLyX (ORCPT ); Wed, 7 Oct 2015 07:54:23 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36331 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbbJGLyV (ORCPT ); Wed, 7 Oct 2015 07:54:21 -0400 From: Sudip Mukherjee To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] regulator: core: fix build warning Date: Wed, 7 Oct 2015 17:24:14 +0530 Message-Id: <1444218854-17944-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We were getting warning about: warning: 'regulator_lock_supply' defined but not used warning: 'regulator_unlock_supply' defined but not used It appears that there is no user of regulator_lock_supply() and regulator_unlock_supply(). Commit 9f01cd4a915e ("regulator: core: introduce function to lock regulators and its supplies") says there will be future users, but as of now there is no user and is creating build warnings. Signed-off-by: Sudip Mukherjee --- drivers/regulator/core.c | 39 --------------------------------------- 1 file changed, 39 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 7896ef5..3ba7131 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -133,45 +133,6 @@ static bool have_full_constraints(void) } /** - * regulator_lock_supply - lock a regulator and its supplies - * @rdev: regulator source - */ -static void regulator_lock_supply(struct regulator_dev *rdev) -{ - struct regulator *supply; - int i = 0; - - while (1) { - mutex_lock_nested(&rdev->mutex, i++); - supply = rdev->supply; - - if (!rdev->supply) - return; - - rdev = supply->rdev; - } -} - -/** - * regulator_unlock_supply - unlock a regulator and its supplies - * @rdev: regulator source - */ -static void regulator_unlock_supply(struct regulator_dev *rdev) -{ - struct regulator *supply; - - while (1) { - mutex_unlock(&rdev->mutex); - supply = rdev->supply; - - if (!rdev->supply) - return; - - rdev = supply->rdev; - } -} - -/** * of_get_regulator - get a regulator device node based on supply name * @dev: Device pointer for the consumer (of regulator) device * @supply: regulator supply name -- 1.9.1